Verified Commit f3b3e975 authored by Hercules Merscher's avatar Hercules Merscher 🌴
Browse files

refactor: Rename id to covered_experience

parent e4598982

lib/labkit/covered_experience/experience.rb

+2 −2
Original line number Diff line number Diff line
@@ -100,13 +100,13 @@ module Labkit 
      private



      def base_labels

        @base_labels ||= @definition.to_h.slice(:id, :feature_category, :urgency)

        @base_labels ||= @definition.to_h.slice(:covered_experience, :feature_category, :urgency)

      end



      def ensure_started!

        return @started unless @started.nil?



        err = UnstartedError.new("Covered Experience #{@definition.id} not started")

        err = UnstartedError.new("Covered Experience #{@definition.covered_experience} not started")



        warn(err)

        raise(err) if %w[development test].include?(ENV['RAILS_ENV'])

lib/labkit/covered_experience/registry.rb

+2 −2
Original line number Diff line number Diff line
@@ -8,7 +8,7 @@ require 'labkit/logging/json_logger' 


module Labkit

  module CoveredExperience

    Definition = Data.define(:id, :description, :feature_category, :urgency)

    Definition = Data.define(:covered_experience, :description, :feature_category, :urgency)



    class Registry

      extend Forwardable
@@ -79,7 +79,7 @@ module Labkit 
        return nil unless content.is_a?(Hash)



        errors = JSON::Validator.fully_validate(schema, content)

        return Definition.new(id: experience_id, **content) if errors.empty?

        return Definition.new(covered_experience: experience_id, **content) if errors.empty?



        warn("Invalid schema for #{file_path}")

spec/labkit/covered_experience/experience_spec.rb

+2 −2
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do 
            stub_env('RAILS_ENV', env)

          end



          it { expect { checkpoint }.to raise_error(Labkit::CoveredExperience::UnstartedError, "Covered Experience #{definition.id} not started") }

          it { expect { checkpoint }.to raise_error(Labkit::CoveredExperience::UnstartedError, "Covered Experience #{definition.covered_experience} not started") }

        end

      end

    end
@@ -130,7 +130,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do 
            stub_env('RAILS_ENV', env)

          end



          it { expect { complete }.to raise_error(Labkit::CoveredExperience::UnstartedError, "Covered Experience #{definition.id} not started") }

          it { expect { complete }.to raise_error(Labkit::CoveredExperience::UnstartedError, "Covered Experience #{definition.covered_experience} not started") }

        end

      end

    end

spec/labkit/covered_experience/registry_spec.rb

+2 −2
Original line number Diff line number Diff line
@@ -39,13 +39,13 @@ RSpec.describe Labkit::CoveredExperience::Registry do 
        registry = described_class.new(dir: covered_experiences_dir)



        expect(registry[:merge_request_creation]).to eq Labkit::CoveredExperience::Definition.new(

          id: "merge_request_creation",

          covered_experience: "merge_request_creation",

          description: 'Creating a new merge request in a project',

          feature_category: 'source_code_management',

          urgency: 'sync_fast'

        )

        expect(registry[:issue_creation]).to eq Labkit::CoveredExperience::Definition.new(

          id: 'issue_creation',

          covered_experience: 'issue_creation',

          description: 'Creating a new issue in a project',

          feature_category: 'team_planning',

          urgency: 'sync_fast'