Verified Commit c8f6f13a authored by Hercules Merscher's avatar Hercules Merscher 🌴
Browse files

fix: Format user experience SLI's time values

parent cf2643b6

lib/labkit/user_experience_sli/experience.rb

+3 −3
Original line number Diff line number Diff line
@@ -236,9 +236,9 @@ module Labkit 
          user_experience_id: id,

          feature_category: @definition.feature_category,

          urgency: @definition.urgency,

          start_time: @start_time,

          checkpoint_time: @checkpoint_time,

          end_time: @end_time,

          start_time: @start_time&.iso8601(3),

          checkpoint_time: @checkpoint_time&.iso8601(3),

          end_time: @end_time&.iso8601(3),

          elapsed_time_s: elapsed_time,

          urgency_threshold_s: urgency_threshold

        )

spec/labkit/user_experience_sli/experience_spec.rb

+6 −6
Original line number Diff line number Diff line
@@ -14,7 +14,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 


  let(:event_info) do

    definition.to_h.slice(:user_experience_id, :feature_category, :urgency).merge(

      start_time: a_kind_of(Time),

      start_time: a_kind_of(String),

      elapsed_time_s: a_kind_of(Numeric),

      urgency_threshold_s: a_kind_of(Integer),

    )
@@ -62,7 +62,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
          user_experience_id: 'testing_sample',

          feature_category: 'source_code_management',

          urgency: 'sync_fast',

          start_time: be_a(Time),

          start_time: be_a(String),

          elapsed_time_s: be_a(Numeric),

          urgency_threshold_s: 2,

        )
@@ -170,7 +170,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
          .and_call_original



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(Time)))

          .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(String)))

          .ordered

          .and_call_original
@@ -245,7 +245,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
            .and_call_original



          expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

            .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(Time)))

            .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(String)))

            .ordered

            .and_call_original
@@ -296,7 +296,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
      it { expect { checkpoint }.to checkpoint_user_experience(:testing_sample) }



      it 'logs checkpoint time' do

        checkpoint_event_info = event_info.merge(checkpoint: 'intermediate', checkpoint_time: a_kind_of(Time))

        checkpoint_event_info = event_info.merge(checkpoint: 'intermediate', checkpoint_time: a_kind_of(String))



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**checkpoint_event_info))
@@ -327,7 +327,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
      it { expect { complete }.to complete_user_experience(:testing_sample) }



      it 'logs completion time' do

        complete_event_info = event_info.merge(checkpoint: 'end', end_time: a_kind_of(Time))

        complete_event_info = event_info.merge(checkpoint: 'end', end_time: a_kind_of(String))



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**complete_event_info))