Verified Commit 7e8b9983 authored by Stan Hu's avatar Stan Hu
Browse files

Relax Sidekiq version 

We now use Sidekiq 6 in production, but Sidekiq 5 is fine.

This allows us to ship only one version in Omnibus.
parent 08fcb1eb

gitlab-labkit.gemspec

+1 −1
Original line number Diff line number Diff line
@@ -42,6 +42,6 @@ Gem::Specification.new do |spec| 
  spec.add_development_dependency "rspec", "~> 3.10.0"

  spec.add_development_dependency "rspec-parameterized", "~> 0.4"

  spec.add_development_dependency "rufo", "0.9.0"

  spec.add_development_dependency "sidekiq", "~> 5.2.7"

  spec.add_development_dependency "sidekiq", ">= 5.2"

  spec.add_development_dependency "webrick", "~> 1.7.0"

end

spec/labkit/middleware/sidekiq/client_spec.rb

+1 −1
Original line number Diff line number Diff line
@@ -17,7 +17,7 @@ describe Labkit::Middleware::Sidekiq::Client do 
      fake_middleware = double("middleware")

      expect(middleware).to receive(:new).and_return(fake_middleware)

      expect(fake_middleware).to receive(:call)

                                   .with("DummyWorker", a_hash_including("args" => ["hello"]), anything, anything)

                                   .with(test_worker.class, a_hash_including("args" => ["hello"]), anything, anything)



      test_worker.perform_async("hello")

    end