fix: Renaming checkpoint_category to checkpoint_action (48dafa36) · Commits · GitLab.org / ruby / gems / labkit-ruby

lib/labkit/covered_experience/experience.rb

+3 −3

Original line number	Diff line number	Diff line
		@@ -86,7 +86,7 @@ module Labkit
		# @param extra [Hash] Additional data to include in the log
		def resume(**extra, &)
		ensure_started!
		checkpoint(checkpoint_category: 'resume', **extra)
		checkpoint(checkpoint_action: 'resume', **extra)

		return self unless block_given?

		@@ -242,7 +242,7 @@ module Labkit

		def to_proc(**extra)
		lambda do
		checkpoint(checkpoint_category: "push_to_context", **extra)
		checkpoint(checkpoint_action: "push_to_context", **extra)
		{ "start_time" => @start_time.iso8601(3) }
		end
		end
		@@ -267,7 +267,7 @@ module Labkit

		@start_time = Time.iso8601(processed_data["start_time"])
		checkpoint_counter.increment(checkpoint: "intermediate")
		log_event("intermediate", checkpoint_category: "load_from_context")
		log_event("intermediate", checkpoint_action: "load_from_context")
		end

		def warn(err, **extra)

spec/labkit/covered_experience/experience_spec.rb

+9 −9

Original line number	Diff line number	Diff line
		@@ -93,7 +93,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do

		# Proc should trigger a checkpoint event when called
		expect(Labkit::CoveredExperience.configuration.logger).to receive(:info)
		.with(hash_including(checkpoint: 'intermediate', checkpoint_category: 'push_to_context'))
		.with(hash_including(checkpoint: 'intermediate', checkpoint_action: 'push_to_context'))
		.ordered
		.and_call_original

		@@ -166,7 +166,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do

		# Proc should trigger a checkpoint event when called
		expect(Labkit::CoveredExperience.configuration.logger).to receive(:info)
		.with(hash_including(checkpoint: 'intermediate', checkpoint_category: 'push_to_context'))
		.with(hash_including(checkpoint: 'intermediate', checkpoint_action: 'push_to_context'))
		.ordered
		.and_call_original

		@@ -235,7 +235,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do

		it 'logs resume and end events' do
		expect(Labkit::CoveredExperience.configuration.logger).to receive(:info)
		.with(hash_including(**event_info, checkpoint: 'intermediate', checkpoint_category: 'resume'))
		.with(hash_including(**event_info, checkpoint: 'intermediate', checkpoint_action: 'resume'))
		.ordered
		.and_call_original

		@@ -252,7 +252,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do
		.with(hash_including(
		**event_info,
		checkpoint: 'intermediate',
		checkpoint_category: 'resume',
		checkpoint_action: 'resume',
		session_id: 'session-789'
		))
		.ordered
		@@ -281,7 +281,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do

		it 'logs resume event' do
		expect(Labkit::CoveredExperience.configuration.logger).to receive(:info)
		.with(hash_including(**event_info, checkpoint: 'intermediate', checkpoint_category: 'resume'))
		.with(hash_including(**event_info, checkpoint: 'intermediate', checkpoint_action: 'resume'))
		.and_call_original

		resume
		@@ -292,7 +292,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do
		.with(hash_including(
		**event_info,
		checkpoint: 'intermediate',
		checkpoint_category: 'resume',
		checkpoint_action: 'resume',
		resumed_by: 'worker-123'
		))
		.and_call_original
		@@ -662,7 +662,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do
		.with(hash_including(
		**event_info,
		checkpoint: 'intermediate',
		checkpoint_category: 'load_from_context'
		checkpoint_action: 'load_from_context'
		))
		.and_call_original

		@@ -699,7 +699,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do
		.with(hash_including(
		**event_info,
		checkpoint: 'intermediate',
		checkpoint_category: 'load_from_context'
		checkpoint_action: 'load_from_context'
		))
		.and_call_original

		@@ -723,7 +723,7 @@ RSpec.describe Labkit::CoveredExperience::Experience, :with_metrics_config do

		it 'does not log load_from_context event' do
		expect(Labkit::CoveredExperience.configuration.logger).not_to receive(:info)
		.with(hash_including(checkpoint_category: 'load_from_context'))
		.with(hash_including(checkpoint_action: 'load_from_context'))

		loaded_experience
		end

spec/labkit/covered_experience_spec.rb

+4 −4

Original line number	Diff line number	Diff line
		@@ -262,7 +262,7 @@ RSpec.describe Labkit::CoveredExperience, :with_metrics_config do
		.with(
		hash_including(
		checkpoint: 'intermediate',
		checkpoint_category: 'load_from_context',
		checkpoint_action: 'load_from_context',
		covered_experience: 'testing_sample',
		)
		)
		@@ -273,7 +273,7 @@ RSpec.describe Labkit::CoveredExperience, :with_metrics_config do
		.with(
		hash_including(
		checkpoint: 'intermediate',
		checkpoint_category: 'resume',
		checkpoint_action: 'resume',
		covered_experience: 'testing_sample',
		user_id: 789,
		request_id: 'req-123'
		@@ -290,7 +290,7 @@ RSpec.describe Labkit::CoveredExperience, :with_metrics_config do
		.with(
		hash_including(
		checkpoint: 'intermediate',
		checkpoint_category: 'load_from_context',
		checkpoint_action: 'load_from_context',
		covered_experience: 'testing_sample',
		)
		)
		@@ -301,7 +301,7 @@ RSpec.describe Labkit::CoveredExperience, :with_metrics_config do
		.with(
		hash_including(
		checkpoint: 'intermediate',
		checkpoint_category: 'resume',
		checkpoint_action: 'resume',
		covered_experience: 'testing_sample',
		user_id: 789,
		request_id: 'req-123'