Verified Commit 25d73cd2 authored by Hercules Merscher's avatar Hercules Merscher 🌴
Browse files

fix: Renaming a_kind_of matchers to be_a for consistency

parent c8f6f13a

spec/labkit/user_experience_sli/experience_spec.rb

+7 −7
Original line number Diff line number Diff line
@@ -14,9 +14,9 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 


  let(:event_info) do

    definition.to_h.slice(:user_experience_id, :feature_category, :urgency).merge(

      start_time: a_kind_of(String),

      elapsed_time_s: a_kind_of(Numeric),

      urgency_threshold_s: a_kind_of(Integer),

      start_time: be_a(String),

      elapsed_time_s: be_a(Numeric),

      urgency_threshold_s: be_a(Integer),

    )

  end
@@ -170,7 +170,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
          .and_call_original



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(String)))

          .with(hash_including(**event_info, checkpoint: 'end', end_time: be_a(String)))

          .ordered

          .and_call_original
@@ -245,7 +245,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
            .and_call_original



          expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

            .with(hash_including(**event_info, checkpoint: 'end', end_time: a_kind_of(String)))

            .with(hash_including(**event_info, checkpoint: 'end', end_time: be_a(String)))

            .ordered

            .and_call_original
@@ -296,7 +296,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
      it { expect { checkpoint }.to checkpoint_user_experience(:testing_sample) }



      it 'logs checkpoint time' do

        checkpoint_event_info = event_info.merge(checkpoint: 'intermediate', checkpoint_time: a_kind_of(String))

        checkpoint_event_info = event_info.merge(checkpoint: 'intermediate', checkpoint_time: be_a(String))



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**checkpoint_event_info))
@@ -327,7 +327,7 @@ RSpec.describe Labkit::UserExperienceSli::Experience, :with_metrics_config do 
      it { expect { complete }.to complete_user_experience(:testing_sample) }



      it 'logs completion time' do

        complete_event_info = event_info.merge(checkpoint: 'end', end_time: a_kind_of(String))

        complete_event_info = event_info.merge(checkpoint: 'end', end_time: be_a(String))



        expect(Labkit::UserExperienceSli.configuration.logger).to receive(:info)

          .with(hash_including(**complete_event_info))