- /lib/rubocop/cop/gitlab_security/deep_munge.rb
- /lib/rubocop/cop/migration/update_large_table.rb
- /lib/rubocop/cop/line_break_around_conditional_block.rb

Changelog: fixed

Adding good and bad examples to three cops

See merge request gitlab-org/ruby/gems/gitlab-styles!266

Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Keeyan Nejad <knejad@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: GitLab Duo <gitlab-duo@gitlab.com>
Reviewed-by: Keeyan Nejad <knejad@gitlab.com>
Co-authored-by: Sayeed Ahmad <sayeedahmad2005@gmail.com>

The cop previously flagged any method_name(x) == :foo check inside
on_send, even when x was a child node rather than the on_send parameter
itself. RESTRICT_ON_SEND cannot express constraints on child nodes, so
these were false positives requiring inline disable comments.

Thread the on_send parameter name through the four node matchers so
method_name_plain only matches when the subject is the on_send parameter.

Fixes: #90

Changelog: fixed

Fix UseRestrictOnSend false positives on child-node method name checks

Closes #90

See merge request !267

Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Pranshu Sharma <prsharma@gitlab.com>

FeatureSpecMaxExamples prevents spec files to grow beyond 25 examples.

Changelog: added

Move FeatureSpecMaxExamples cop from GitLab here

See merge request !268

Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Lohit Peesapati <lpeesapati@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Eduardo Sanz García <esanz-garcia@gitlab.com>
Co-authored-by: Eduardo Sanz García <esanz-garcia@gitlab.com>

Bump version to 14.1.0

See merge request !269

Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Co-authored-by: Eduardo Sanz García <esanz-garcia@gitlab.com>