Stop checking file locations programmatically

Problem

Checking file locations in RuboCop cop rules programmatically (via e.g. in_model?) is slow (see stack profile). RuboCop's Include/Exclude directives should be used instead.

Proposed solution

Create a 🆕 👮 rule in InternalAffairs:

1. Ban methods of form in_X(node)? and encourage the use of RuboCop's Include/Exclude configuration directives
2. Ban use of source_buffer.name

Locations

gitlab-styles

• def in_haml?(node)
• def in_controller?(node)
• def in_migration?(node)

gitlab-org/gitlab

• def in_with_lock_retries?(node)
• def in_haml_file?(node)
• def in_routes?(node)
• def in_spec?(node)
• def in_haml_file?(node)
• def in_qa_file?(node)
• def in_finder?(node)
• def in_model?(node)
• def in_service_class?(node)
• def in_presenter?(node)
• def in_serializer?(node)
• def in_worker?(node)
• def in_controller?(node)
• def in_graphql?(node)
• def in_api?(node)
• def in_spec?(node)
• def in_app_directory?(node, directory)
• def in_lib_directory?(node, directory)
• def in_graphql_directory?(node, directory)
• def in_migration?(node)
• def in_background_migration?(node)
• def in_ee_background_migration?(node)
• def in_deployment_migration?(node)
• def in_post_deployment_migration?(node)

Prior discussion

The following discussion from !156 (merged) should be addressed:

• @splattael started a discussion:

  A potential follow-up is to write a InternalAffairs cop to ban use of:

  1. Methods of form in_X(node)?
  2. Ban use of source_buffer.name

  In gitlab-styles I see:

  • def in_haml?(node)
  • def in_controller?(node)
  • def in_migration?(node)

  In gitlab-org/gitlab I see more:

  • def in_with_lock_retries?(node)
  • def in_haml_file?(node)
  • def in_routes?(node)
  • def in_spec?(node)
  • def in_haml_file?(node)
  • def in_qa_file?(node)
  • def in_finder?(node)
  • def in_model?(node)
  • def in_service_class?(node)
  • def in_presenter?(node)
  • def in_serializer?(node)
  • def in_worker?(node)
  • def in_controller?(node)
  • def in_graphql?(node)
  • def in_api?(node)
  • def in_spec?(node)
  • def in_app_directory?(node, directory)
  • def in_lib_directory?(node, directory)
  • def in_graphql_directory?(node, directory)
  • def in_migration?(node)
  • def in_background_migration?(node)
  • def in_ee_background_migration?(node)
  • def in_deployment_migration?(node)
  • def in_post_deployment_migration?(node)