Pin all runtime dependencies

See merge request !255



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Add missing good and bad examples to cops

See merge request !256



Merged-by: Brian Williams <bwilliams@gitlab.com>
Approved-by: Keeyan Nejad <knejad@gitlab.com>
Approved-by: Brian Williams <bwilliams@gitlab.com>
Reviewed-by: Keeyan Nejad <knejad@gitlab.com>
Co-authored-by: Kiran Kumawat <kiran.kumawat1991@gmail.com>

This indicates that `gitlab-styles` is the single source of truth for
RuboCop dependency configurations in used projects.

Release version 13.1.0

See merge request !253



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Lawrence Chou <choznerol@protonmail.com>

Bump Rubocop to 1.71.1 and address 28 new `InternalAffairs/*` violations

Closes #84

See merge request !254



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Chou Yu Ta <lawrencechou1024@gmail.com>
Co-authored-by: Chou Yu Ta <lawrencechou1024@gmail.com>
Co-authored-by: Lawrence Chou <choznerol@protonmail.com>

Chou Yu Ta authored 1 month ago and Peter Leitzen committed 1 month ago

Changelog: changed

Disallow Endless Methods

Closes #72

See merge request !252



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Lawrence Chou <choznerol@protonmail.com>

Close #72

Changelog: added

Add RSpec/RailsControllerTesting rule

Closes #32

See merge request !250



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Manuel Schonlaub <manuel.schonlaub@prodigygame.com>
Co-authored-by: Manuel Schönlaub <manuel.schoenlaub@gmail.com>

Manuel Schönlaub authored 1 month ago and Peter Leitzen committed 1 month ago

Add cop to ban deprecated method usage in RSpec controller tests

Add a cop that triggers when using assigns or render_template
from within controller and request tests, instead of using the
request body for assertions.

Changelog: added

Release 13.0.2

See merge request !249



Merged-by: Doug Stull <dstull@gitlab.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Add cop to prevent usage of max-width CSS utils

See merge request !239



Merged-by: Brian Williams <bwilliams@gitlab.com>
Approved-by: Sashi Kumar Kumaresan <skumar@gitlab.com>
Approved-by: Brian Williams <bwilliams@gitlab.com>
Co-authored-by: Peter Hegman <phegman@gitlab.com>

Resolve "Bump rubocop to 1.68.0"

Closes #81

See merge request !247



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Aboobacker MK <akarakath@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Daniel Prause <dprause@gitlab.com>

Daniel P. authored 3 months ago and Peter Leitzen committed 3 months ago

Changelog: changed

We want to try and only use min-width CSS utils to keep our codebase
consistent and our bundle size small

Style/HashSyntax: Set EnforcedShorthandSyntax to `either_consistent`

See merge request !246



Merged-by: David Dieulivol <ddieulivol@gitlab.com>
Approved-by: Keeyan Nejad <knejad@gitlab.com>
Approved-by: David Dieulivol <ddieulivol@gitlab.com>
Reviewed-by: Keeyan Nejad <knejad@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Examples:

  # good - `foo` and `bar` values can be omitted, but they are consistent,
  so it's accepted
  {foo: foo, bar: bar}

  # bad - `bar` value can be omitted
  {foo:, bar: bar}

  # bad - mixed syntaxes
  {foo:, bar: baz}

  # good
  {foo:, bar:}

  # good - can't omit `baz`
  {foo: foo, bar: baz}

See also gitlab-org/gitlab!161622

Changelog: changed

Clarify release process for external contributors

See merge request !244



Merged-by: Doug Stull <dstull@gitlab.com>
Approved-by: Doug Stull <dstull@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Martin Schurz <Martin.Schurz@telekom.de>

Release version 13.0.1

See merge request !243



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Upgrade RuboCop to 1.67.0

See merge request !242



Merged-by: Rémy Coutable <remy@rymai.me>
Approved-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Rémy Coutable <remy@rymai.me>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

lib/rubocop/cop/gitlab_security/json_serialization.rb:33: warning:
Inheriting from `RuboCop::Cop::Cop` is deprecated. Use
`RuboCop::Cop::Base` instead.  For more information, see
https://docs.rubocop.org/rubocop/v1_upgrade_notes.html.

With that we can also remove the monkey patch for
`InternalAffairs/CopDescriptionWithExample` as it's no longer needed and
fails now.

Changelog: other

Change RSpec/ExampleWithoutDescription style to single_line_only

See merge request !241



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: drew stachon <730684-drew@users.noreply.gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Abdul Wadood <awadood@gitlab.com>

Abdul Wadood authored 4 months ago and Peter Leitzen committed 4 months ago

>>>
For empty test description blocks, use `specify` rather than `it do` if the
test is self-explanatory.
>>>

The [RSpec/ExampleWithoutDescription cop](https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#rspecexamplewithoutdescription)
is enabled by default. Here we are changing the EnforcedStyle of the cop to
[single_line_only](https://docs.rubocop.org/rubocop-rspec/cops_rspec.html#enforcedstyle-single_line_only)
to match the above quoted [testing guidelines](https://docs.gitlab.com/ee/development/testing_guide/best_practices.html#general-guidelines).

## Examples

```ruby
# bad
it do

# good
specify do
```

## Impact on gitlab-org/gitlab

```
bundle exec rubocop $f --only RSpec/ExampleWithoutDescription
39218 files inspected, 1181 offenses detected
```

Changelog: added

Release version 13.0.0

See merge request !237



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Martin Schurz <Martin.Schurz@telekom.de>

Don't override `relevant_file?`

See merge request !238



Merged-by: Thong Kuah <tkuah@gitlab.com>
Approved-by: Thong Kuah <tkuah@gitlab.com>
Reviewed-by: Keeyan Nejad <knejad@gitlab.com>
Co-authored-by: Peter Leitzen <pleitzen@gitlab.com>

Also, add missing rubocop-factory_bot.yml and rubocop-code_reuse.yml to
rubocop-default.yml.

Use `Include` directive instead.

Upgrade RuboCop (to 1.66.0) and rubocop extensions

See merge request !232



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Martin Schurz <2090677-schurzi@users.noreply.gitlab.com>
Co-authored-by: Martin Schurz <Martin.Schurz@telekom.de>

Martin Schurz authored 6 months ago and Peter Leitzen committed 6 months ago

* RuboCop 1.65.1
* RuboCop FactoryBot 2.26.1
* RuboCop GraphQL 1.5.4
* RuboCop Performance 1.21.1
* RuboCop Rails 2.26.0
* RuboCop RSpec 2.31.0

Changelog: changed

Add an internal affairs cop to require examples

See merge request !236



Merged-by: Peter Leitzen <pleitzen@gitlab.com>
Approved-by: Peter Leitzen <pleitzen@gitlab.com>
Reviewed-by: Peter Leitzen <pleitzen@gitlab.com>
Co-authored-by: Keeyan Nejad <knejad@gitlab.com>

Keeyan Nejad authored 6 months ago and Peter Leitzen committed 6 months ago

This cop ensures we include good and bad examples with any cop we define

Changelog: added

Add a cop to prevent interpolated Tailwind utils

See merge request !234



Merged-by: Brian Williams <bwilliams@gitlab.com>
Approved-by: Brian Williams <bwilliams@gitlab.com>
Co-authored-by: Paul Gascou-Vaillancourt <paul.gascvail@gmail.com>