The linter.suggestion? may not have worked since 2020-06-09
@godfat-gitlab observed that Danger wasn't catching suggestion commits like gitlab-org/gitlab!29438 (e95ad491)
This seems due to the linter format being different than the default suggestion commit message: https://gitlab.com/gitlab-org/gitlab-dangerfiles/-/blob/master/lib/gitlab/dangerfiles/commit_linter.rb#L40-42 commit.message.start_with?("Apply suggestion to")
and https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/suggestions/commit_message.rb Apply %{suggestions_count} suggestion(s) to %{files_count} file(s)
@gl-quality/eng-prod - Before changing the rule to account for this we need to consider the impact. It has been 10 months that this rule has likely not fired in Danger and "reactivating" it may have some adverse consequences. Additionally, this hadn't been raised as an explicit concern anywhere that I'm aware of.
To take a dissenting view on this, what is the downside of downgrading the failure for suggestions to a warning in the Dev Guidelines instead of updating the danger rule and causing a lot of new failures for Engineers?