2018-06-12: 11.0.0.rc13 exception request for gitlab-org/gitlab-ce!19600

Exception request

  • Merge request to be considered for picking: gitlab-org/gitlab-ce!19600

Why it needs to be picked

This MR is important because it fixes an incorrect exclusive lease (in fact too exclusive) in the upload object storage migration. The main benefit of this MR is to enable the migration to (correctly) happen concurrently, for all upload types. This has come to light after it was decided to use the upload migration as part of the GCP Migration. There are currently no alternative, as the lease key that is use is too broad for some uploader type.

Potential negative impact of picking

The main thing that could go wrong would be to break the migration process, we (@ahanselka and @mbergeron) should test on staging. The uploads on staging have already been migrated to object storage by @ahanselka. We'll take some time to migrate some of these back and forth and then use the https://sentry.gitlap.com/gitlab/staginggitlabcom/?query=is%3Aunresolved+Sidekiq%2FObjectStorage to validate that:

  1. files are migrated successfully
  2. no ExclusiveLeaseTaken are raised in the process.

The potential user is pretty low, as the migration has to be manually kicked-off. We can also configure the number of upload to migrate per batch, so we can ramp-up as we go.

Sign-off

The following need to provide initial approval for this exception request:

If you are the last person to provide initial approval, assign this issue to the VPE for his approval:

After the VPE approves, check that the following is accurate before closing this issue:

  • gitlab-org/gitlab-ce!19600 has the correct milestone and label set so that the release managers will pick it.
  • gitlab-org/gitlab-ce!19600 has a comment with a link to this issue:
    • Exception approved in ISSUE_LINK

/cc @jprovaznik

Edited by Mayra Cabrera