2018-01-10: 10.4 exception request for gitlab-org/gitlab-ee!3935
Exception request
Merge request to be considered for picking: gitlab-org/gitlab-ee!3935
Why it needs to be picked
- Support for artifacts should already exist in Geo. Geo is not really complete without it
- Due to general time-pressure on Geo, it is valuable to be able to find regressions or areas for improvement early
Potential negative impact of picking
- There is an
after_destroy
callback onCi::JobArtifact
. If it fails then it could cause 500s when erasing builds. The code is not too complex though, it just creates aJobArtifactDeletedEvent
- A
geo_
table and foreign key is created, and columns are added to anothergeo_
table, and complications during migrations are more difficult to recover from than rolling back code
But,
- The feature is a new addition, so the risk of breaking existing functionality is relatively low
- It only adds to Geo, which is not enabled on GitLab.com
- The migrations are simple, and similar to previous migrations
- The code is similar to existing code for LFS objects and uploads
Sign-off
See https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3935#note_53624000
Edited by Michael Kozono