2018-03-12: 10.6.0.rc4 exception request for gitlab-org/gitlab-ce!17630
Exception request
Merge request to be considered for picking: gitlab-org/gitlab-ce!17630
Why it needs to be picked
This improves the performance of the merge requests show page slightly, by reducing the number of calls we make to Gitaly. This page won't be fast afterwards, but it will be faster.
Picking this change will let us identify the next area of improvement on this page, now that we know one of the existing issues has been addressed.
Potential negative impact of picking
This is already pretty well-covered by specs. I tested the potential performance impact in production: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17630#note_62740795
The biggest risk was that other users of a compare don't like this change, but I think the MR has been adjusted to not impact those now.
Sign-off
-
Release manager: @jameslopez -
Engineering lead: @DouweM -
Engineering director: @tommy.morgan
Note: if you're the last person to sign off, please add the 10.6 milestone and the Pick Into 10.6 label to gitlab-org/gitlab-ce!17630.