2018-11-06 11.5.2 exception request for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22916
Exception request
- Merge request to be considered for picking: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22916
Why it needs to be picked
We broke impersonation tokens generation in the admin screen in a 11.4.x (and other backports) security release. This patch doesn't have to go into 11.5.0, but we really should fix this by 11.5.1 because we get daily reports about this issue.
Potential negative impact of picking
I still see some concerns about the merge request that should be addressed in a follow-up merge request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22916#note_117630911.
Release manager sign-off
(Assign this issue to RMs managing this release. See https://about.gitlab.com/release-managers/)
A release manager (not a trainee) needs to provide initial approval for this exception request.
-
Release manager -
Engineering Manager, Development
Mention others as necessary during discussion.
Sign-off for RC (delete this section if patch release)
-
Engineering Manager, Quality
If you are the last person to provide initial approval, assign this issue to the VPE for their approval:
-
VPE
After approval
Check that the following is accurate before closing this issue:
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22916 has the correct milestone and label set so that the release managers will pick it. -
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/22916 has a comment with a link to this issue: - Exception approved in ISSUE_LINK
/cc: @ifarkas