2018-09-14: 11.3 exception request for gitlab-org/gitlab-ee!7338
Exception request
- Merge request to be considered for picking: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7338
Why it needs to be picked
This MR allows self-managed customers to use the protected environments feature. The configure team wanted to test the potential impact this MR would have prior to merging. Testing on gitlab.com was satisfactory and the MR is simply removing the feature flag (see https://gitlab.com/gitlab-org/gitlab-ee/issues/7206#note_101307231)
Potential negative impact of picking
It doesn't touch any feature code, risk of impact is minimal.
Release manager sign-off
(Assign this issue to RMs managing this release. See https://about.gitlab.com/release-managers/)
A release manager (not a trainee) needs to provide initial approval for this exception request.
-
Release manager: @reprazent or @dstanley
Mention others as necessary during discussion.
Sign-off for RC (delete this section if patch release)
Upon initial approval, the release manager will then ping and assign the following roles:
-
Engineering team leader: @DylanGriffith -
Engineering department leader (if different from team leader): @dhavens -
Quality leader: @meks
If you are the last person to provide initial approval, assign this issue to the VPE for his approval:
-
VPE: @edjdev
After approval
Check that the following is accurate before closing this issue:
-
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7338 has the correct milestone and label set so that the release managers will pick it. -
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7338 has a comment with a link to this issue: - Exception approved in #443 (closed)