2018-06-13: 11.0.2 exception request for gitlab-org/gitlab-ce!19501
Exception request
- Merge request to be considered for picking: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19501
Why it needs to be picked
On GitLab.com, job artifacts and LFS objects are in object storage, and uploads are in the process of being migrated to object storage.
We need to ensure the integrity of these files before we migrate to GCP, and we need enough time to correct missing/bad data if that is the case. The current GCP migration date looks like mid-July, so I think any 11.0.X patch release before July makes sense. I ask for 11.0.3 to reduce the amount of change in 11.0.2. If accepted, I will set a reminder to myself to add ~"Pick into 11.0" at the right time.
Alternatively, I could manually verify files in Rails console on staging and then prod. This approach has a bit more fat-finger risk.
Potential negative impact of picking
Virtually zero potential impact on production or customer installations, since only file check rake task code was touched.
Sign-off
The following need to provide initial approval for this exception request:
-
Release manager: @mayra-cabrera -
Engineering team leader: @stanhu -
Engineering department leader (if different from team leader): @tommy.morgan -
Quality leader: @meks
If you are the last person to provide initial approval, assign this issue to the VPE for his approval:
-
VPE: @edjdev
After the VPE approves, check that the following is accurate before closing this issue:
-
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19501 has the correct milestone and label set so that the release managers will pick it. -
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19501 has a comment with a link to this issue: - Exception approved in #274 (closed)