Danger: Reduce restrictions on number of changes without a description
Chat conversation: https://gitlab.slack.com/archives/C02PF508L/p1536862385000100
mkozono [2 hours ago] I appreciate the spirit of enforcing good commit messages but https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/7315#note_101252849 feels like bureaucracy. I feel this commit message is good enough in this case and it’s a pain to reword and force push a commit. Now that I see it in practice, I expect it will be easy to find other cases with good one line commits with more than 20 lines changed. I suggest we disable this check, or raise the limit to avoid false positives, until we have an easy way to perform that task in GitLab UI. Thoughts?
rspeicher [2 hours ago] Yeah, especially as that commit only changed 20+ lines in a spec file. Maybe we could do something like "30 or more lines among 3 or more files"
rspeicher [2 hours ago] cc
@yorickpeterse
@marin
mkozono [2 hours ago]
30 or more lines among 3 or more files I like this idea too
andr3 [2 hours ago] I had an MR today that had 19+ 1- and bam!
😄 I just about made the cut!😄 But I second that,
👍 Since we always have at least one file changed, the changelog, I'd suggest 4 files. (edited)mkozono [1 hour ago] with respect to the changelog, should we specify that it have its own commit? I’m generally on the fence about that, but it impacts this rule idea “X lines across Y files” as well as “maximum X commits per MR”
rspeicher [1 hour ago] That's true. I don't think a separate commit should be required for a changelog, but in that case we should have anything in
changelogs/
excluded from the count.yorickpeterse [1 minute ago] We can bump the limit and make it a warning
yorickpeterse [1 minute ago] The idea was to prevent people from changing 50000 lines, then write "fixed typo" as the commit message
yorickpeterse [< 1 minute ago] The suggestion of 30 more lines for 3 or more files is also a good alternative (edited)