Follow-up from "Fix customer contribution notifier to not check for community author on merge event"
The following discussion from !94 (merged) should be addressed:
-
@alberts-gitlab started a discussion: (+1 comment) @markglenfletcher I think it's also worth keeping
community_contribution?
check, so for non-community MR, we don't need to locate org name, which may be expensive.I noticed my revert MR was picked up by this notifier. Found out about it in https://sentry.gitlab.net/gitlab/triage-serverless/issues/2638816/?environment=production&referrer=alert_email
The problem with community_contribution?
is that it checks the event's author username against the group members' usernames, but we'd need to check the resource's author ID (since we only have the ID, not the username) against the group members' IDs.
I think we'd need a new Triage.gitlab_org_group_member_ids
(and similar methods to other groups for consistency) and checks against IDs instead of usernames.