E2E test for merge request reviewer assignment with approval rules
Reviewers are replacing Approvers, while adding a Reviewer role independent of an Assignee.
The concept of approval still exists, as well as the approval rules feature.
We should add a test that covers the reviewer assignment workflow when there are code owner and approval rules in place
See:
- gitlab-org&1823
- gitlab-org/gitlab#233736 (closed) (scheduled for 13.6)
- gitlab-org/gitlab#231244 (closed)
Steps
- Add a CODEOWNERS file.
- Create an MR.
- Add approval rules for:
- a single user
- multiple users
- a group
- Request a review from one user for each rule.
- Confirm that:
- reviewers appear in the sidebar (gitlab-org/gitlab#237921 (closed))
- reviewers appear in the MR list (gitlab-org/gitlab#237922 (closed))
- todos are generated (gitlab-org/gitlab#216054 (closed))
- system notes are generated (gitlab-org/gitlab#243777 (closed))
- As each reviewer, add a comment and approve the MR.
- Confirm that the MR shows that the reviewers commented and approved the MR.
Edited by Mark Lapierre