Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
testcases
testcases
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 700
    • Issues 700
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • quality
  • testcasestestcases
  • Issues
  • #1039

Closed
Open
Opened Sep 23, 2020 by Mark Lapierre@mlapierreOwner

E2E tests for merge request reviewer assignment workflow

The feature replaces Approvers with Reviewers, while adding a Reviewer role independent of an Assignee.

See gitlab-org&1823

Steps

EE test

  1. Create an MR.
  2. Request a review from multiple users.
  3. Confirm that:
    • reviewers appear in the sidebar (gitlab-org/gitlab#237921 (closed))
    • reviewers appear in the MR list (gitlab-org/gitlab#237922 (closed))
    • todos are generated (gitlab-org/gitlab#216054 (closed))
    • system notes are generated (gitlab-org/gitlab#243777 (closed))
  4. As each reviewer, add a comment and approve the MR.
  5. Confirm that the MR shows that the reviewers commented and approved the MR.

CE test

Same as the EE test, but only one reviewer should be allowed (gitlab-org/gitlab#246905 (closed)). Also, see gitlab-org/gitlab#10294 (comment 417076058) regarding showing that the reviewer commented.

Edited Sep 23, 2020 by Mark Lapierre
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: gitlab-org/quality/testcases#1039