Refactor existing tests to use dynamic element validation

Refactor existing tests to use dynamic element validation.

  • Dynamic element validation, not only adds stability to the tests due to it's waiting, it also implicitly tests GitLab.
  • Many Pages are utilizing click_element but not specifying a page / partial that we expect to be on. We should start adding these in to ensure our test suite is waiting a sufficient amount of time, and to test these pages/partials.

This is meant to be handled as an ongoing effort. - gitlab-org/gitlab#39208 (comment 293641644)