Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • T team-tasks
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 334
    • Issues 334
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Requirements
    • Requirements
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Insights
    • Issue
    • Repository
    • Value stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • quality
  • team-tasks
  • Issues
  • #550

Closed
Open
Created Jun 16, 2020 by Mark Lapierre@mlapierreOwner

Update tests and docs to use `RSpec.describe` as the outer block

In RSpec 4.0 its monkey patching will be disabled by default, which means the describe, context, and other methods won't be available globally anymore.

  • https://relishapp.com/rspec/rspec-core/docs/configuration/zero-monkey-patching-mode
  • https://rspec.info/blog/2013/07/the-plan-for-rspec-3/#zero-monkey-patching-mode

The unit/integration spec files have already been updated: gitlab-org/gitlab#220018 (closed)

Some of the docs have been updated, and the rest will be too: gitlab-org/gitlab#220218 (closed)

We use an outer context block in the E2E tests. We should change that to RSpec.describe, to be consistent with all the other spec files, and we should update our docs (including the beginner's guide).

Assignee
Assign to
Time tracking