Scan for feature flag changes in more paths
What happened
There was an S1 incident involving SAML SSO. gitlab-com/gl-infra/production#5904 (closed)
Though we have recently added functionality to detect feature flag changes and run package-and-qa with the FF both off and on, we did not catch this issue.
The original MR gitlab-org/gitlab!69448 (merged) had a change in config/feature_flags/ops/mask_page_urls.yml
. Package-and-qa on feature flag jobs are being triggered on change in %r{/feature_flags/development/.*\.yml}
https://gitlab.com/gitlab-org/gitlab/blob/cb151316287380f56db4e7ddbc66fb6afa9c0797/scripts/changed-feature-flags#L22 thus the job was not triggered.
Corrective action to be taken
Explore scanning for changes in feature_flags/ops
. Are there any other paths we should also add?
@sliaquat @mlapierre assigning to the two of you to triage and take action. Please add a weight per the weighting guidelines once you understand the scope of work. Thank you both.