Fail earlier if a test attempts to flip feature flags without appropriate RSpec metadata
Problem
A fix (Add :skip_live_env group_audit_logs_1_spec.rb (gitlab-org/gitlab!154789 - merged)) was filed after a test started failing in Canary.
This failure should not have made it far enough to reach Canary.
Proposal
Implement a detection mechanism on the end-to-end tests that fail the end-to-end test if it attempts to flip feature flags without containing the appropriate RSpec metadata (:skip_live_env
)
Possibility: Make a Cop to enforce this?
Edited by Dan Davison