Skip to content

Review Ops::Verify E2E tests to evaluate which tests can be merged with other tests.

Bringing @richard.chong finding up here as issue description since we only decided to merge 1 pair of tests

So from our discussion in #1533 (closed), there is only pipeline_editor_can_create_merge_request_spec.rb that I think could be discussed as a potential for merging with update_ci_file_with_pipeline_editor_spec.rb. The rest of the other specs I identified as possible candidates aren't plausible due to possibly making the pipeline more complex thus making the test itself run slower and more prone to failures.

Regarding merging pipeline_editor_can_create_merge_request_spec.rb and update_ci_file_with_pipeline_editor_spec.rb. I added a note asking if the 2 specs are identical but, actually, I was wondering if we can merge them where we update the CI file with the pipeline editor and then tick the box to create a new merge request before submitting the changes. That way it does the "update ci file with editor" that's part of update_ci_file_with_pipeline_editor_spec and then also will "create a merge request upon submit" that's part of pipeline_editor_can_create_merge_request_spec.

Edited by Tiffany Rea