Context selection issue with 'dependency_proxy_spec'

Goal

Fix context selection for 'dependency_proxy_spec' to ensure it's running in places where orchestrated can run - QA main and nightly packages

Details

dependency_proxy_spec is being skipped in GitLab main QA pipelines, however it should run based on dependency_proxy_spec.rb#L4

  RSpec.describe 'Package', :orchestrated, :registry, only: { pipeline: :main }, product_group: :container_registry do

only: { pipeline: :main } was added in Fix registry related tests (gitlab-org/gitlab!73825 - merged) based on gitlab-org/gitlab#344246 (comment 725097281)

these tests can't be running on a pipeline other than master, or where we can orchestrate the scenarios

If we look at latest master pipeline - this test is not running - https://gitlab.com/gitlab-org/gitlab/-/jobs/3964710241 or Omnibus pipeline example https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/3951876756

It appears to be caused by the way pipeline context selection works:

if option[:pipeline].present?
   return true if Runtime::Env.ci_project_name.blank?

    return pipeline_matches?(option[:pipeline])

....
def pipeline_matches?(pipeline_to_run_in)
   Array(pipeline_to_run_in).any? { |pipeline| pipeline.to_s.casecmp?(pipeline_from_project_name(Runtime::Env.ci_project_name)) }
end

added Quality bugfunctional devopspackage groupcontainer registry typebug labels

mentioned in merge request gitlab-org/omnibus-gitlab!6759 (merged)

@svistas could you please take a look if that's a bug? Context gitlab-org/omnibus-gitlab!6759 (comment 1320856717)

:oh-no: yes, this looks like a bug unless I am missing where else we could be passing ENV['CI_PROJECT_NAME'] perhaps it should suffice to add this variable with the project name explicitly. I can try taking a look at this, thanks for finding this

added sectionops label

assigned to @svistas

unassigned @svistas

added vintage label

Hi @niskhakova ,

Thanks for raising this bug.

Contributions like this are vital to help make GitLab a better product.

We would be grateful for your help in verifying whether your bug report requires further attention from the team. If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please comment on this issue.

This issue has been inactive for more than 12 months now and based on the policy for inactive bugs, will be closed in 7 days.

Thanks for your contributions to make GitLab better!

added stale label

added sectionci label and removed sectionops label

Hi @niskhakova ,

Based on the policy for inactive bugs, this issue is now being closed.

If you think this bug still exists, and is reproducible with the latest stable version of GitLab, please reopen this issue.

Thanks for your contributions to make GitLab better!

closed

added auto closed label