Handle reviewer with 馃敶 emoji or "Busy" status better in Reviewer roulette

Feedback

Gathered feedback from https://gitlab.com/gitlab-org/quality/engineering-productivity/team/-/issues/377:

I now catch myself using GitLab Review Workload Dashboard instead of reviewer roulette when I see that the suggested team member has 馃敶 or Busy status. My worry is that by ignoring these statuses we only increase mean time to merge.

  1. People still use 馃敶 or Busy but they will still be suggested by Reviewer Roulette and it is easy to miss that they have a 馃敶 status. Sometimes I ask them to review a MR only to find out a couple days later that they still haven't reviewed it because they didn't have capacity.
  2. If you really need to catch up (such as coming back from PTO) there is no way to prevent getting reviews. I've actually kept my OOO status set for an extra day so I can catch up but this is misleading because I am actually not OOO.

The biggest thing that I run into is that Roulette suggests users that have Busy or 馃敶 set. So either I don't notice this and ask them to review or I do notice and then have to go to https://gitlab-org.gitlab.io/gitlab-roulette/ and find a new reviewer.

I keep running into this. I now check status before assigning because it's adding time to my MR review cycle to wait 2 days and reassign to another person.

I still think there's a "shoulder" to PTO returns that's not well accounted for. Similar to @peterhegman's comment above I actually missed this change while I was out on parental leave, so on my first day back from months of leave I received multiple review requests, which isn't ideal. I was missing context, had a huge backlog, and in the midst of transitioning back. In some cases reviews can feel refreshing to become re-involved but it can also can feel like being thrown in the deep-end. Perhaps this isn't something worth solving with the effort of automation. As long as we're supportive, the reviewer could simply decline and ask for the review to be reassigned. It feels like a problem we should have a simple solution to solving and if that's as simple as documenting guidance, I'd be supportive of that.

Ideas

Maybe we could make it so Reviewer roulette respects Busy but you can only have it set for a certain amount of time (maybe a day?). Then if you really need a day to catch up you can set Busy but it is cleared after a day. Would probably need to introduce some sort of new setting to make this happen so might not be worth it.