Thursday 2025-01-30 16:56 UTC - `gitlab-org/gitlab` broken `master` with rubocop

gitlab-org/gitlab pipeline #1648847481 failed

Pipeline ID	Branch	Commit	Merge request	Source	Duration	Triggered by
1648847481	master	Merge branch 'remove-coverage-check-learn-more-link' into 'master'	Remove "Learn more." link from coverage check in MR approval rules	push	58.91 minutes	Zack Cuddy

Failed jobs (1):

• rubocop Job ID: 8998850150 (retry with @gitlab-bot retry_job 8998850150)

Attribution:

This incident is unattributed and posted in #master-broken.

How to close this incident

• Follow the steps in the Broken master handbook guide to
  • escalate
  • triage, and
  • resolve
• Reminder: apply the appropriate ~master-broken:* label to document root cause before closing the incident.

Quick Tips:

• you can retry all failing jobs with @gitlab-bot retry_pipeline 1648847481.
• a message can be posted in #backend_maintainers or #frontend_maintainers to get a maintainer take a look at the fix ASAP.
• add the pipelineexpedited label, and master:broken or master:foss-broken label, to speed up the master-fixing pipelines.

added master-brokenundetermined master:broken labels

Root Cause Analysis

• rubocop: master-brokenundetermined.

Closing as a duplicate of incident #10185 (closed). Please reopen it if you don't think this is a duplicate.

marked this issue as a duplicate of #10185 (closed)

closed

changed the incident status to Resolved by closing the incident

marked this incident as related to #10185 (closed)

added auto closed closedduplicate labels

changed the incident status to Resolved

Investigation Steps

• rubocop:

  rubocop --parallel --format RuboCop::Formatter::GracefulFormatter

This might take a while...
Inspecting 40902 files


Offenses:

db/migrate/20241107232900_add_ai_settings_table.rb:9:38: W: [Correctable] Lint/RedundantCopDisableDirective: Unnecessary disabling of Migration/EnsureFactoryForTable.
    create_table :ai_settings do |t| # rubocop:disable Migration/EnsureFactoryForTable -- FactoryBot does not support Singleton classes https://github.com/thoughtbot/factory_bot/issues/642
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

40902 files inspected, 1 offense detected, 1 offense autocorrectable
scripts/utils.sh: line 274: pop_var_context: head of shell_variables not a function context

added backend label

Duration Analysis

added missedSLA label

added master-brokenneed-merge-train label and removed master-brokenundetermined label