Reporting Module: Fix empty spreadsheet email error
Overview
When running a migrate, an error was encountered if no email was specified for a given group/project on a wave. This was fixed with a dirty if statement on the spot. We were under the impression this had been fixed before. e.g. from reporting.py;
if user := self.usersClient.find_user_by_email_comparison_without_id(self.project.get('swc_manager_email')):
self.assignee = user['username']
else:
self.assignee = None
the usersClient.find_user_by_email() should gracefully handle being passed a None
.
Tasks
-
Fix users.py.usersClient.find_user_by_email() client to handle this gracefully
Acceptance Criteria
-
Existing UTs pass locally -
100% code coverage on new code
Weight estimation
@leopardm @pprokic @mlindsay @nicki_peric @bryan-may @jordan_ng
Please leave your weight estimation as a reaction to this issue (reference). The final weight will be one level higher than the majority weight.
Move issue to customer facing project
In case of customer facing projects that cannot use the same issue/MR from Congregate
- Once the issue is weighted move it to the customer facing project by changing its epic
- Update milestone and iteration if needed
- Reopen the issue in Congregate
- Make sure the 2 issues are related
- MR's should only exist in Congregate and
- Once you create one from the issue manually update the MR description
- Add the customer facing project issue link to
Closes #<congregate_issue_no> <customer_issue_link>
so that the MR closes both when merged
- Make sure to
/spend
all your time in the customer facing project issue