## :pencil: Summary Track delivery of the **S05 Maven Format Phase 1 Tests**: the `pkg/client/maven` HTTP client surface, the `pkg/conformance/maven` `Module` + `mvn` driver wiring, and one `TestDescriptor` per non-optional Maven catalog row. After this plan's last MR merges, the Maven `Module`'s `TestCatalog` returns the full Phase 1 inventory — 27 `Local` rows + 3 `Errors` rows + 1 `Negative auth` row — and `inventory_test.go` asserts strict equality against [docs/catalog/maven.md](https://gitlab.com/gitlab-org/ops/registry-conformance/-/blob/main/docs/catalog/maven.md)'s non-`optional`, non-`Virtual` rows. The 27 Steps map 1:1 to S05 acceptance criteria #1– #33. Builds on the S04 foundation harness (#28). ## :link: Spec and plan - :scroll: Spec: [S05 Maven Protocol](https://gitlab.com/gitlab-org/ops/registry-conformance/-/blob/main/docs/specs/S05-maven-protocol.md) - :clipboard: Plan: [2026-05-20 Maven Format](https://gitlab.com/gitlab-org/ops/registry-conformance/-/blob/main/docs/plans/2026-05-20-maven-format.md) ## :tools: Scope Per the plan's Approach section, 27 MR-sized Steps in three logical bands: 1. **Steps 1–5 — `pkg/client/maven` HTTP surface** (5 MRs): per-operation methods, metadata XML types, SNAPSHOT filename helpers, checksum sidecars, on top of the S04 foundation 1.8 client shell. 2. **Steps 6–9a — `pkg/conformance/maven` module + driver wiring** (5 MRs): the Maven `env` + `requireMVN` skip-gate, the `mvn` `CLIExecutor` wrapper, the `internal/fixture` builders (POM / settings / JAR / metadata), the async-metadata polling helper, and the env→client accessor seam + shared fake `CLIExecutor` test harness. 3. **Steps 10–27 — per-AC test functions + inventory enforcement** (18 MRs): each Step adds one or a few `TestDescriptor` rows and their `Fn`, flips the catalog row(s) to `done`, and re-runs the inventory subset assertion. Step 10 lands the subset guard first; Step 27 flips it to strict equality last. ## :chart_with_upwards_trend: Status | Step | Description | MR | Status | Done | Assignee | Dependencies | |------|-------------|----|--------|------|----------|--------------| | 1 | `pkg/client/maven/client.go` — credential mapping + RFC 9457 invariant | !81 | ~"workflow::complete" | [x] | @radbatnag | #28 step 8 (client shell) | | 2 | `pkg/client/maven/artifact.go` — GET / HEAD / PUT artifact | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/96 | ~"workflow::complete" | [x] | @mkhalifa3 | step 1 | | 3 | `pkg/client/maven/snapshot.go` — SNAPSHOT PUT + filename helpers | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/121 | ~"workflow::complete" | [x] | @mkhalifa3 | step 2 | | 4 | `pkg/client/maven/metadata.go` — maven-metadata.xml client surface | !86 | ~"workflow::complete" | [x] | @radbatnag | step 1 | | 5 | `pkg/client/maven/checksum.go` — checksum sidecar GET / PUT | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/97 | ~"workflow::complete" | [x] | @mkhalifa3 | step 1 | | 6 | `pkg/conformance/maven` env + `requireMVN` + NewEnv | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/123 | ~"workflow::complete" | [x] | @mkhalifa3 | step 7; #28 step 7 (module shell) | | 7 | `pkg/conformance/maven/cliexec.go` — Maven CLIExecutor wrapper | !92 | ~"workflow::complete" | [x] | @radbatnag | #28 step 25 (cliexec Executor) | | 8 | `pkg/conformance/maven/internal/fixture/*` — POM / settings / JAR / metadata | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/132 | ~"workflow::complete" | [x] | @mkhalifa3 | step 4 | | 9 | `pkg/conformance/maven/poll.go` — async-metadata polling helper | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/125 | ~"workflow::complete" | [x] | @mkhalifa3 | step 4 | | 9a | `pkg/conformance/maven` env accessor seam + mvn-driven test harness | !149 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 1, 6, 7 | | 10 | Maven inventory subset assertion | https://gitlab.com/gitlab-org/ops/registry-conformance/-/merge_requests/127 | ~"workflow::complete" | [x] | @mkhalifa3 | step 6; #28 step 26 (catalogparse / MR 1.12) | | 11 | publish.release + publish.classifier + publish.pom-only | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 4, 5, 6, 7, 8, 9a, 10 | | 12 | publish.partial-deploy-state + empty-file + pgp-signature | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 4, 5, 6, 8, 9a, 10 | | 13 | publish.groupid-path-layout + groupid-depth | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 6, 8, 9a, 10 | | 14 | publish.duplicate-release-rejection | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 6, 8, 9a, 10 | | 15 | publish.snapshot-timestamped + snapshot-classifier | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 3, 4, 6, 7, 8, 9a, 10 | | 16 | pull.release + parent-pom-resolution + classifier-only | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 6, 7, 8, 9a, 10 | | 17 | pull.snapshot-timestamped | !150 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 3, 4, 6, 7, 8, 9a, 10 | | 18 | metadata.versions-list + release-out-of-order + last-updated-format | !151 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 4, 6, 8, 9a, 10 | | 19 | metadata.snapshot-version-preservation | !151 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 4, 6, 8, 9a, 10 | | 20 | metadata.async-sync-consistency | !151 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 4, 6, 8, 9, 9a, 10 | | 21 | http.head-request + expect-100-continue + content-type | !151 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 4, 6, 8, 9a, 10 | | 22 | concurrency.snapshot-deploys | !151 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 3, 4, 6, 7, 8, 9a, 10 | | 23 | checksum.sha1-md5 + sha256-sha512 | !152 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 5, 6, 7, 8, 9a, 10 | | 24 | checksum.sha1-sidecar-match | !152 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 5, 6, 8, 9a, 10 | | 25 | error.not-found-artifact + duplicate-release-body + rfc-9457-problem-details | !152 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 1, 2, 6, 8, 9a, 10, 14 | | 26 | negative.unauthenticated | !152 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 2, 6, 9a, 10 | | 27 | inventory strict-equality flip | !152 | ~"workflow::complete" | [x] | @mkhalifa3 | steps 11–26 | **MR** — filled in when the step MR is opened. A merged MR is the only completion signal for a step. ## :link: Dependencies - **Spec S05** (`docs/specs/S05-maven-protocol.md`) — merged and locked (!21). - **Spec S04** (`docs/specs/S04-contracts.md`) — merged and locked (!11). - **S04 Phase 1 Foundation Harness** (#28) — Steps 1–9a here build on the per-format shells from #28 step 7 (module shell / MR 1.7) and #28 step 8 (client shell / MR 1.8), and on the logger helpers from #28 step 5 (MR 1.5). Step 10 additionally needs the cross-format `catalogparse` helper (#28 step 26 / MR 1.12). Step 7 and every `mvn`-driven per-AC Step need the foundation's `pkg/conformance/cliexec` `Executor` — #28 step 25 (Group 4 / MR 4.1). - **S04 foundation Group 2 (CLI) and Group 3 (report)** — NOT required for Maven Steps 1–27 to land. The Maven slice is exercised via `go test ./pkg/conformance/maven/...` and `go test ./pkg/client/maven/...` in CI; end-to-end via the binary becomes possible once Groups 2+3 land but does not gate these Steps. - **`mvn` binary in the CI image** — the repo's Dockerfile already provisions `mvn`; `docker-image-smoke` verifies `mvn --version`. No new image work. ## :no_entry_sign: Out of scope / deferred Per the plan's Out-of-scope section: - **Cross-format runner, CLI flags, exit-code mapping, report rendering, slog JSON handler** — owned by the S04 foundation plan (#28), not re-litigated here. - **The `## Virtual` catalog section** (5 rows: `maven.virtual.upstream-resolution-order`, `maven.virtual.metadata-merging`, `maven.virtual.cache-ttl`, `maven.virtual.degraded-upstream`, `maven.virtual.allow-deny-rules`) — deferred to a follow-up spec that adds the upstream-config surface. Rows stay `not started` and are filtered out of the inventory assertion's RHS. - **The 5 `optional`-status `Local` rows** (`maven.http.conditional-get`, `maven.http.transfer-encoding-chunked`, `maven.pull.non-unique-snapshot`, `maven.http.retry-5xx`, `maven.metadata.plugin-prefix`) — depend on registry behavior the conformance contract does not require. - **Auth-matrix expansion** (Deploy-Token, Job-Token, Bearer over `Authorization`, Nexus user-tokens) — deferred to a future auth-matrix spec per S04 / S05 §Resolutions. ## :twisted_rightwards_arrows: Step dependency map Visualisation of the Dependencies column in the Status table. Nodes prefixed `F.` are external foundation (#28) hooks; bare numbered nodes are Steps in this issue (#29). ```mermaid flowchart LR F8[✅ #28 step 8<br/>client shell / MR 1.8] F7[✅ #28 step 7<br/>module shell / MR 1.7] F25[✅ #28 step 25<br/>cliexec Executor / MR 4.1] FCP[✅ #28 step 26<br/>catalogparse / MR 1.12 — not built] S1[✅ 1 · client.go] S2[👀 2 · artifact.go] S3[3 · snapshot.go] S4[👀 4 · metadata.go] S5[✅ 5 · checksum.go] S6[6 · env + requireMVN] S7[✅ 7 · cliexec.go] S8[8 · internal/fixture/*] S9[9 · poll.go] S9A[9a · env accessor seam + fake CLIExecutor] S10[10 · inventory subset] S11[11 · publish.release/classifier/pom-only] S12[12 · publish.partial-deploy/empty/pgp] S13[13 · publish.groupid-path/depth] S14[14 · publish.duplicate-release] S15[15 · publish.snapshot-timestamped/classifier] S16[16 · pull.release/parent-pom/classifier-only] S17[17 · pull.snapshot-timestamped] S18[18 · metadata.versions-list/oo/last-updated] S19[19 · metadata.snapshot-version-preservation] S20[20 · metadata.async-sync-consistency] S21[21 · http.head/expect-100/content-type] S22[22 · concurrency.snapshot-deploys] S23[23 · checksum.sha1-md5/sha256-sha512] S24[24 · checksum.sha1-sidecar-match] S25[25 · error.not-found/duplicate/rfc-9457] S26[26 · negative.unauthenticated] S27[27 · inventory strict-equality flip] F8 --> S1 S1 --> S2 S2 --> S3 S1 --> S4 S1 --> S5 F7 --> S6 S7 --> S6 F25 --> S7 S4 --> S8 S4 --> S9 S1 --> S9A S6 --> S9A S7 --> S9A S6 --> S10 FCP --> S10 S2 --> S11 S4 --> S11 S5 --> S11 S6 --> S11 S7 --> S11 S8 --> S11 S9A --> S11 S10 --> S11 S2 --> S12 S4 --> S12 S5 --> S12 S6 --> S12 S8 --> S12 S9A --> S12 S10 --> S12 S2 --> S13 S6 --> S13 S8 --> S13 S9A --> S13 S10 --> S13 S2 --> S14 S6 --> S14 S8 --> S14 S9A --> S14 S10 --> S14 S3 --> S15 S4 --> S15 S6 --> S15 S7 --> S15 S8 --> S15 S9A --> S15 S10 --> S15 S2 --> S16 S6 --> S16 S7 --> S16 S8 --> S16 S9A --> S16 S10 --> S16 S3 --> S17 S4 --> S17 S6 --> S17 S7 --> S17 S8 --> S17 S9A --> S17 S10 --> S17 S2 --> S18 S4 --> S18 S6 --> S18 S8 --> S18 S9A --> S18 S10 --> S18 S4 --> S19 S6 --> S19 S8 --> S19 S9A --> S19 S10 --> S19 S2 --> S20 S4 --> S20 S6 --> S20 S8 --> S20 S9 --> S20 S9A --> S20 S10 --> S20 S2 --> S21 S4 --> S21 S6 --> S21 S8 --> S21 S9A --> S21 S10 --> S21 S3 --> S22 S4 --> S22 S6 --> S22 S7 --> S22 S8 --> S22 S9A --> S22 S10 --> S22 S2 --> S23 S5 --> S23 S6 --> S23 S7 --> S23 S8 --> S23 S9A --> S23 S10 --> S23 S2 --> S24 S5 --> S24 S6 --> S24 S8 --> S24 S9A --> S24 S10 --> S24 S1 --> S25 S2 --> S25 S6 --> S25 S8 --> S25 S9A --> S25 S10 --> S25 S14 --> S25 S2 --> S26 S6 --> S26 S9A --> S26 S10 --> S26 S11 --> S27 S12 --> S27 S13 --> S27 S14 --> S27 S15 --> S27 S16 --> S27 S17 --> S27 S18 --> S27 S19 --> S27 S20 --> S27 S21 --> S27 S22 --> S27 S23 --> S27 S24 --> S27 S25 --> S27 S26 --> S27 ```