## What `TestMavenRepositoryStore_ReVerifyRepositoryAlive` covers fewer row shapes than the two suites it mirrors. The Maven suite has 6 subtests. The npm suite has 10. The container suite has 10 `t.Run` call sites, and 2 of them sit in a loop over 2 formats, so it runs 12 cases. Three subtests exist in both mirrors and in neither Maven form. This issue adds those three to the Maven suite. Every line number in this issue is read at `origin/main` `7307bd94a`. Line numbers move, so find each subtest by its name and not by its number. | Suite | File | Function at `7307bd94a` | |---|---|---| | Maven | `internal/datastore/maven_repositories_integration_test.go` | line 251 | | npm | `internal/datastore/npm_repositories_integration_test.go` | line 522 | | container | `internal/datastore/container_repository_integration_test.go` | line 373 | ### The Maven suite today | Line | Subtest name | |---|---| | 256 | `returns nil for a live hosted maven repository` | | 264 | `returns ErrNotFound for a soft-deleted repository` | | 275 | `returns ErrNotFound for a non-hosted maven repository` | | 283 | `returns ErrNotFound for a missing repository id` | | 290 | `holds a FOR SHARE lock that blocks a concurrent soft-delete` | | 336 | `leaves maven_repositories unlocked while it waits on the repositories row` | `MavenRepositoryStore.ReVerifyRepositoryAlive` is at `internal/datastore/maven_repositories.go:248`. Its `WHERE` clause refuses a row on five legs: the child namespace, the child id, `repositories.format`, `repositories.kind`, and `repositories.soft_deleted_at`. The join adds a sixth leg, which binds the parent namespace to the child namespace. The table above shows that three of those legs have no negative case of their own. ## The three gaps ### A wrong-format parent The npm mirror is `returns ErrNotFound for a maven-format repository with an npm binding` (`npm_repositories_integration_test.go:564`). It seeds a `repositories` row with the maven format and an `npm_repositories` binding on that row, then asserts `ErrNotFound`. The subtest carries its own reason: "The binding is seeded on purpose, so the join matches and the format predicate is the only leg left that can refuse the row." The container mirror is a loop over two formats at `container_repository_integration_test.go:431`. It runs `returns ErrNotFound for a maven-format repository with a container binding` and the npm-format twin of that name. The Maven form seeds a `repositories` row with a format other than maven, plus a `maven_repositories` binding on it. `seedMavenRepositoryNamed` (`maven_repositories_integration_test.go:458`) already takes the format as a parameter and always writes the maven binding, so the case needs no new helper. The suite's other helper, `seedMavenRepository` (`internal/datastore/maven_seed_integration_test.go:71`), writes the maven format only, which is why the case is absent today. ### A repository id from another namespace The npm mirror is `returns ErrNotFound for an npm repository id from another namespace` (`npm_repositories_integration_test.go:582`). It seeds two namespaces and one hosted npm repository in namespace A. It then calls the method with namespace B and the id from namespace A. The subtest carries its own reason: "Two namespace legs bind here, the child's own and the join's, so a cross-tenant miss is what shows neither was dropped." The container mirror is `returns ErrNotFound for a container repository id from another namespace` (`container_repository_integration_test.go:449`). The Maven suite has no cross-namespace case for this method. The missing-id case at line 283 is not a substitute, because a random id misses on the child id leg alone. ### The remote kind `repositories.kind` has three values: `RepositoryKindHosted`, `RepositoryKindVirtual`, and `RepositoryKindRemote` (`internal/datastore/repositories.go:68-72`). The method admits the hosted value only. The npm suite refuses the other two values in two subtests: `returns ErrNotFound for a virtual npm repository` (`npm_repositories_integration_test.go:546`) and `returns ErrNotFound for a remote npm repository` (line 555). The container suite does the same at lines 406 and 415. The Maven suite has one subtest for both values, `returns ErrNotFound for a non-hosted maven repository` (line 275). That subtest seeds `RepositoryKindVirtual` only. The remote value therefore has no case, and the subtest name claims more than the body tests. Split it in two, as both mirrors do, and name each kind. ## Why it matters Merge request !2268 wrote the npm and container suites whole. The Maven suite predates them and was never brought level. Issue #399 proposes one sweep that rewrites the `qrm.ErrNoRows` branch at every read site in `internal/datastore`. Its Scope rests on the suites that exist: > Covered by the existing store suites: each store already asserts both the no-rows mapping and that a transient DB failure is not misreported as `ErrNotFound`. For `MavenRepositoryStore.ReVerifyRepositoryAlive` the no-rows half of that claim holds for three refusal shapes and not for the three above. A sweep that changes the mapping for this method keeps a green suite either way. The wrong-format, cross-namespace, and remote-kind rows can stop mapping correctly and no test reports it. ## Not in scope The transient-database-failure subtest is a fourth mirror gap in the same suite. Issue #1166 closes it, in the Maven repository, package, and version suites together. Do not add it here. This issue covers `TestMavenRepositoryStore_ReVerifyRepositoryAlive` only. `MavenPackageStore.ReVerifyPackageAlive` and `MavenVersionStore.ReVerifyVersionAlive` have no npm or container mirror, so no mirror gap can be measured against them. ## The handle in each new subtest must be a transaction Pass a transaction to `ReVerifyRepositoryAlive`, never `client.DB()`. Issue #1166 adds a run-time guard to this method. While that guard is unmerged, the method accepts the connection pool. Once it merges, the method refuses a `*sql.DB` handle and returns its own sentinel before it runs any statement. A subtest written with the pool then reports that sentinel. It reaches none of the six `WHERE` legs, so it proves nothing about the row shape it exists to pin. What happens next depends on the assertion. An assertion of `require.ErrorIs(err, ErrNotFound)`, which is the shape all three mirrors use, fails and is easy to see. A weaker assertion such as a bare `require.Error` passes and hides the problem. Each new subtest should therefore keep the `require.ErrorIs(err, ErrNotFound)` shape of the mirror it comes from. The mirrors open the transaction with `beginTx(t, client.DB())` (`internal/datastore/npm_write_integration_test.go:118`). At `7307bd94a`, 15 files in `internal/datastore` use that helper, and `maven_repositories_integration_test.go` is not one of them. The Maven suite opens its transactions inline. Issue #1166 also moves the existing pool call sites in this suite to a transaction handle. Once it merges, the neighbours of the new subtests carry the correct shape. _This is a bot message 🤖 — /smurfit_