Ensure the file content is a String

Romain Tartièrerequested to merge
smortex/omnibus-gitlab:stringify-content into master

Passing an integer to some configuration parameters prevent gitlab omnibus from configuring the service correctly, e.g.

mattermost['env'] = {
  "MM_EMAILSETTINGS_SMTPPORT" => 25
}

cause an exception to be raised:

================================================================================
Error executing action `create` on resource 'env_dir[/var/opt/gitlab/mattermost/env]'
================================================================================

Chef::Exceptions::ValidationFailed
----------------------------------
Property content must be one of: String, nil!  You passed 25.

The problem was initialy detected in the puppet-gitlab module, and the maintainer suggested that the problem would rather be fixed here: https://github.com/voxpupuli/puppet-gitlab/issues/289

Merge request reports