Error while upgrade to 11.0.0
I'm running Ubuntu 16.04 and using the omnibus packages. I updated Gitlab to 11.0.0-ee.0 today and the upgrade failed when trying to compile the cookbooks.
Here is the output from the upgrade.
Setting up gitlab-ee (11.0.0-ee.0) ...
Checking PostgreSQL executables:Starting Chef Client, version 13.6.4
resolving cookbooks for run list: ["gitlab::config", "postgresql::bin"]
Synchronizing Cookbooks:
- gitlab (0.0.1)
- postgresql (0.1.0)
- registry (0.1.0)
- package (0.1.0)
- mattermost (0.1.0)
- consul (0.0.0)
- gitaly (0.1.0)
- nginx (0.1.0)
- letsencrypt (0.1.0)
- runit (0.14.2)
- acme (3.1.0)
- crond (0.1.0)
- compat_resource (12.19.0)
Installing Cookbook Gems:
Compiling Cookbooks...
================================================================================
Recipe Compile Error in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb
================================================================================
TypeError
---------
no implicit conversion of nil into String
Cookbook Trace:
---------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:49:in `join'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:49:in `block in parse_git_data_dirs'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `each'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `map'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `parse_git_data_dirs'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:26:in `parse_variables'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:174:in `block in generate_config'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `each'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `generate_config'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb:26:in `from_file'
Relevant File Content:
----------------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:
42: def parse_git_data_dirs
43: Gitlab['git_data_dirs'] = { "default" => { "path" => "/var/opt/gitlab/git-data" } } if Gitlab['git_data_dirs'].empty?
44:
45: Gitlab['gitlab_rails']['repositories_storages'] =
46: Hash[Mash.new(Gitlab['git_data_dirs']).map do |name, data_directory|
47: shard_gitaly_address = data_directory['gitaly_address'] || gitaly_address
48:
49>> defaults = { 'path' => File.join(data_directory['path'], 'repositories'), 'gitaly_address' => shard_gitaly_address }
50: params = data_directory.merge(defaults)
51:
52: [name, params]
53: end]
54: end
55:
56: def parse_gitaly_storages
57: return unless Gitlab['gitaly']['storage'].nil?
58:
System Info:
------------
chef_version=13.6.4
platform=ubuntu
platform_version=16.04
ruby=ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-linux]
program_name=/opt/gitlab/embedded/bin/chef-client
executable=/opt/gitlab/embedded/bin/chef-client
Running handlers:
There was an error running gitlab-ctl reconfigure:
no implicit conversion of nil into String
Running handlers complete
Chef Client failed. 0 resources updated in 07 seconds
Checking PostgreSQL executables: NOT OK
Could not update PostgreSQL executables.
Shutting down all GitLab services except those needed for migrations
ok: down: alertmanager: 0s, normally up
ok: down: gitlab-monitor: 1s, normally up
ok: down: gitlab-workhorse: 0s, normally up
ok: down: logrotate: 1s, normally up
ok: down: nginx: 0s, normally up
ok: down: node-exporter: 0s, normally up
ok: down: postgres-exporter: 1s, normally up
ok: down: prometheus: 0s, normally up
ok: down: redis-exporter: 1s, normally up
ok: down: sidekiq: 0s, normally up
ok: down: unicorn: 1s, normally up
Ensuring the required services are running
ok: run: postgresql: (pid 20297) 2681215s
ok: run: redis: (pid 20325) 2681214s
ok: run: gitaly: (pid 22841) 1291538s
run: postgresql: (pid 20297) 2681215s; run: log: (pid 3462) 2681649s
run: redis: (pid 20325) 2681214s; run: log: (pid 3357) 2681649s
run: gitaly: (pid 22841) 1291538s; run: log: (pid 3413) 2681649s
Reconfiguring GitLab to apply migrations
Starting Chef Client, version 13.6.4
resolving cookbooks for run list: ["gitlab-ee"]
Synchronizing Cookbooks:
- package (0.1.0)
- gitlab-ee (0.0.1)
- gitlab (0.0.1)
- consul (0.0.0)
- repmgr (0.1.0)
- runit (0.14.2)
- postgresql (0.1.0)
- mattermost (0.1.0)
- registry (0.1.0)
- gitaly (0.1.0)
- nginx (0.1.0)
- letsencrypt (0.1.0)
- crond (0.1.0)
- acme (3.1.0)
- compat_resource (12.19.0)
Installing Cookbook Gems:
Compiling Cookbooks...
================================================================================
Recipe Compile Error in /opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab-ee/recipes/default.rb
================================================================================
TypeError
---------
no implicit conversion of nil into String
Cookbook Trace:
---------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:49:in `join'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:49:in `block in parse_git_data_dirs'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `each'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `map'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:46:in `parse_git_data_dirs'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:26:in `parse_variables'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:174:in `block in generate_config'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `each'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/package/libraries/helpers/settings_helper.rb:172:in `generate_config'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/config.rb:26:in `from_file'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab/recipes/default.rb:26:in `from_file'
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitlab-ee/recipes/default.rb:20:in `from_file'
Relevant File Content:
----------------------
/opt/gitlab/embedded/cookbooks/cache/cookbooks/gitaly/libraries/gitaly.rb:
42: def parse_git_data_dirs
43: Gitlab['git_data_dirs'] = { "default" => { "path" => "/var/opt/gitlab/git-data" } } if Gitlab['git_data_dirs'].empty?
44:
45: Gitlab['gitlab_rails']['repositories_storages'] =
46: Hash[Mash.new(Gitlab['git_data_dirs']).map do |name, data_directory|
47: shard_gitaly_address = data_directory['gitaly_address'] || gitaly_address
48:
49>> defaults = { 'path' => File.join(data_directory['path'], 'repositories'), 'gitaly_address' => shard_gitaly_address }
50: params = data_directory.merge(defaults)
51:
52: [name, params]
53: end]
54: end
55:
56: def parse_gitaly_storages
57: return unless Gitlab['gitaly']['storage'].nil?
58:
System Info:
------------
chef_version=13.6.4
platform=ubuntu
platform_version=16.04
ruby=ruby 2.4.4p296 (2018-03-28 revision 63013) [x86_64-linux]
program_name=/opt/gitlab/embedded/bin/chef-client
executable=/opt/gitlab/embedded/bin/chef-client
Running handlers:
There was an error running gitlab-ctl reconfigure:
no implicit conversion of nil into String
Running handlers complete
Chef Client failed. 0 resources updated in 05 seconds
Checking for an omnibus managed postgresql: OK
Checking for a newer version of PostgreSQL to install
No new version of PostgreSQL installed, nothing to upgrade to
Ensuring PostgreSQL is updated: OK
Restarting previously running GitLab services
ok: run: alertmanager: (pid 17991) 0s
ok: run: gitaly: (pid 22841) 1291546s
ok: run: gitlab-monitor: (pid 18018) 0s
ok: run: gitlab-workhorse: (pid 18020) 1s
ok: run: logrotate: (pid 18029) 0s
ok: run: nginx: (pid 18033) 0s
ok: run: node-exporter: (pid 18053) 1s
ok: run: postgres-exporter: (pid 18059) 0s
ok: run: postgresql: (pid 20297) 2681225s
ok: run: prometheus: (pid 18065) 0s
ok: run: redis: (pid 20325) 2681224s
ok: run: redis-exporter: (pid 18079) 1s
ok: run: sidekiq: (pid 18101) 0s
ok: run: unicorn: (pid 18108) 0s
_______ __ __ __
/ ____(_) /_/ / ____ _/ /_
/ / __/ / __/ / / __ `/ __ \
/ /_/ / / /_/ /___/ /_/ / /_/ /
\____/_/\__/_____/\__,_/_.___/
Upgrade complete! If your GitLab server is misbehaving try running
sudo gitlab-ctl restart
before anything else.
If you need to roll back to the previous version you can use the database
backup made during the upgrade (scroll up for the filename).
Processing triggers for libc-bin (2.23-0ubuntu10) ...
Processing triggers for initramfs-tools (0.122ubuntu8.11) ...
update-initramfs: Generating /boot/initrd.img-4.4.0-36-generic