Installation method for Ubuntu should be running on Linux Mint too.

Description

I followed the installation method for ubuntu on my Linux Mint machine. When running apt-get install gitlab-ce, apt couldn't find the package.

The script(script.deb.sh) detects ${os} and ${dist} params from /etc/lsb-release and generates /etc/apt/sources.list.d/gitlab_gitlab-ce.list. But, these params different between Ubuntu and Linux Mint.

  • Ubuntu 16.04
    • os: ubuntu
    • dist: xenial
  • Linux Mint 18.2
    • os: linuxmint
    • dist: sonya

script.deb.sh results on Linux Mint

/etc/apt/sources.list.d/gitlab_gitlab-ce.list

# this file was generated by packages.gitlab.com for
# the repository at https://packages.gitlab.com/gitlab/gitlab-ce

deb https://packages.gitlab.com/gitlab/gitlab-ce/linuxmint/ sonya main
deb-src https://packages.gitlab.com/gitlab/gitlab-ce/linuxmint/ sonya main

It points a invalid path https://packages.gitlab.com/gitlab/gitlab-ce/linuxmint/.

Proposal

When Linux Mint, convert ${os} and ${dist} params to same as Ubuntu.

script.deb.sh expected results on Linux Mint

/etc/apt/sources.list.d/gitlab_gitlab-ce.list

# this file was generated by packages.gitlab.com for
# the repository at https://packages.gitlab.com/gitlab/gitlab-ce

deb https://packages.gitlab.com/gitlab/gitlab-ce/ubuntu/ xenial main
deb-src https://packages.gitlab.com/gitlab/gitlab-ce/ubuntu/ xenial main

After fix this, the method works on Linux Mint.

Links / references

I found similar issue #24590, but it seems to be inactive.