Setting gitlab user password failing in master
In master, setting the sql_user_password is not working, the resource that is supposed to set the password gives the following:
execute[set password for gitlab postgresql user] action run(skipped due to not_if)
The not if line is
not_if { !helper.is_running? || !helper.user_exists?(username) || helper.user_password_match?(username, password) }
But the execute
resource already has a property named password
. So that is what is being used now instead of the password we are trying to pass.
This code hasn't been changed in months, so it is likely that the chef update (!2273 (merged)) changed/fixed the variables in the guard statements, revealing the bug in our code.
We need to update the code to use new_resource.password
in this execute statement.