sshd in Docker image
Couple of interesting things popped up in discussion in https://gitlab.com/gitlab-org/gitlab-ee/issues/2406.
We are plugging in sshd managing as part of omnibus with https://gitlab.com/gitlab-org/omnibus-gitlab/blob/9-2-stable/docker/assets/setup#L12-18 .
While that is convenient for logging purposes and the fact that we can use our own process supervision on it https://gitlab.com/gitlab-org/omnibus-gitlab/blob/9-2-stable/docker/assets/wrapper#L79 , we don't use it in any other place.
That actually means that we can easily break this functionality because we are not using it anywhere else but in the Docker image. It also was the cause of the previously linked issue.
We should look whether it makes sense to split this out and find different ways of controlling it.