Commit 116266f3 authored by Marin Jankovski's avatar Marin Jankovski

Merge branch '1566-notify-slack-escape-problems' into 'master'

Quote double-quote in commit messages for Slack

Add an inline sed to the commit messages when notifying Slack, resulting in properly quoted double-quote character for the JSON/urlencoded form sent to the API.

Closes #1566

See merge request !1031
parents b368c46c 196d8931
......@@ -309,7 +309,7 @@ notify:slack-fail:
image: "alpine"
stage: notification_fail
script:
- ./support/notify_slack.sh "#omnibus-builds" "(╯°□°)╯︵┻━┻ Build on \`$CI_BUILD_REF_NAME\` failed! Commit \`$(git log -1 --oneline)\` See <https://dev.gitlab.org/gitlab/omnibus-gitlab/commit/"$CI_BUILD_REF"/builds>"
- ./support/notify_slack.sh "#omnibus-builds" "(╯°□°)╯︵┻━┻ Build on \`$CI_BUILD_REF_NAME\` failed! Commit \`$(git log -1 --oneline | sed 's|\"|\\\\\"|g')\` See <https://dev.gitlab.org/gitlab/omnibus-gitlab/commit/"$CI_BUILD_REF"/builds>"
when: on_failure
only:
- master
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment