Backport 'fix-registry-commands-permission-for-non-docker' into '18-5-stable'

What does this MR do?

Merge branch 'fix-registry-commands-permission-for-non-docker' into 'master'

Fix registry permission to restart service if using sudo -u registry

Closes #9423 (closed)

See merge request !8817 (merged)

Merged-by: Hossein Pursultani hpursultani@gitlab.com Approved-by: Lucas Li lli@gitlab.com Approved-by: Hayley Swimelar hswimelar@gitlab.com Approved-by: Hossein Pursultani hpursultani@gitlab.com Reviewed-by: GitLab Duo gitlab-duo@gitlab.com Co-authored-by: João Cunha j.a.cunha@gmail.com

(cherry picked from commit d01e0f07)

61180169 Fix registry gitlab-ctl permissions with sudo -u registry e756744e Fix typo in spec context a294780c Take registry dir from node attrs

Co-authored-by: Hossein Pursultani hpursultani@gitlab.com

Related issues

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

• MR title and description are up to date, accurate, and descriptive.
• MR targeting the appropriate branch.
• Latest Merge Result pipeline is green.
• When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.

For GitLab team members

If you don't have access to this, the reviewer should trigger these jobs for you during the review process.

• The manual Trigger:ee-package jobs have a green pipeline running against latest commit.
• If config/software or config/patches directories are changed, make sure the build-package-on-all-os job within the Trigger:ee-package downstream pipeline succeeded.
• If you are changing anything SSL related, then the Trigger:package:fips manual job within the Trigger:ee-package downstream pipeline must succeed.
• If CI configuration is changed, the branch must be pushed to dev.gitlab.org to confirm regular branch builds aren't broken.

Expected (please provide an explanation if not completing)

• Test plan indicating conditions for success has been posted and passes.
• Documentation created/updated.
• Tests added.
• Integration tests added to GitLab QA.
• Equivalent MR/issue for the GitLab Chart opened.
• Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.