Add support for SLES 15.6
What does this MR do?
Support SLES 15.6 (SP 6) by uploading the OpenSUSE Leap 15.6 package to the SLES repository.
Both OSes are binary compatible as announced in https://www.suse.com/c/introducing-suse-linux-enterprise-15-sp3/.
Relates #8814 (closed)
Changelog: added
This way we can build and publish SLES packages:
- without dev-only builder images, and
- without an additional build job.
Related issues
Relates #8814 (closed)
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
-
MR title and description are up to date, accurate, and descriptive. -
MR targeting the appropriate branch. -
Latest Merge Result pipeline is green. -
When ready for review, MR is labeled workflowready for review per the Distribution MR workflow.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
-
The manualTrigger:ee-package
jobs have a green pipeline running against latest commit. -
Ifconfig/software
orconfig/patches
directories are changed, make sure thebuild-package-on-all-os
job within theTrigger:ee-package
downstream pipeline succeeded. -
If you are changing anything SSL related, then theTrigger:package:fips
manual job within theTrigger:ee-package
downstream pipeline must succeed. -
If CI configuration is changed, the branch must be pushed todev.gitlab.org
to confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
-
Test plan indicating conditions for success has been posted and passes. -
Documentation created/updated. gitlab-omnibus-builder!371 (merged) -
Tests added. -
Integration tests added to GitLab QA. -
Equivalent MR/issue for the GitLab Chart opened. -
Validate potential values for new configuration settings. Formats such as integer10
, duration10s
, URIscheme://user:passwd@host:port
may require quotation or other special handling when rendered in a template and written to a configuration file.
Testing
- Create a SLES 15 SP6 VM
- Upload a OpenSUSE 15.6 package to it
- Install it and run
gitlab-ctl reconfigure
- Confirm reconfigure passes and that all services are healthy
$ grep -i pretty /etc/os-release
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP6"
$ sudo gitlab-ctl status
run: alertmanager: (pid 7015) 76s; run: log: (pid 6696) 130s
run: gitaly: (pid 6975) 79s; run: log: (pid 6060) 293s
run: gitlab-exporter: (pid 6988) 78s; run: log: (pid 6623) 149s
run: gitlab-kas: (pid 6269) 277s; run: log: (pid 6281) 276s
run: gitlab-workhorse: (pid 6888) 80s; run: log: (pid 6456) 165s
run: logrotate: (pid 5976) 307s; run: log: (pid 5988) 304s
run: nginx: (pid 6905) 80s; run: log: (pid 6566) 159s
run: node-exporter: (pid 6969) 79s; run: log: (pid 6607) 153s
run: postgres-exporter: (pid 7024) 75s; run: log: (pid 6718) 124s
run: postgresql: (pid 6106) 283s; run: log: (pid 6117) 282s
run: prometheus: (pid 6999) 78s; run: log: (pid 6677) 135s
run: puma: (pid 6388) 181s; run: log: (pid 6399) 178s
run: redis: (pid 6014) 300s; run: log: (pid 6023) 299s
run: redis-exporter: (pid 6990) 78s; run: log: (pid 6653) 141s
run: sidekiq: (pid 6406) 175s; run: log: (pid 6427) 172s
Merge request reports
Activity
changed milestone to %17.9
assigned to @clemensbeck
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Reviewer Maintainer @jondoveston
(UTC+0, 1 hour behind
@clemensbeck
)@apatterson2
(UTC-7, 8 hours behind
@clemensbeck
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermarked the checklist item When ready for review, MR is labeled workflowready for review per the Distribution MR workflow. as completed
added workflowready for review label
requested review from @jondoveston
- Resolved by Andrew Patterson
added workflowin review label and removed workflowready for review label
E2E Test Result Summary
allure-report-publisher
generated test report!qa-subset-test:
test report for 35559081expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 46 | 0 | 18 | 0 | 64 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 37 | 0 | 0 | 0 | 37 | ✅ | | Govern | 72 | 0 | 3 | 0 | 75 | ✅ | | Verify | 8 | 0 | 2 | 0 | 10 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Systems | 6 | 0 | 1 | 0 | 7 | ✅ | | Monitor | 12 | 0 | 1 | 0 | 13 | ✅ | | Package | 13 | 0 | 8 | 0 | 21 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 221 | 0 | 33 | 0 | 254 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
LGTM
- Pipelines green (including specs)
- Local ce and ee deploy to opensuse-leap 15.6
Edited by Jon Dovestonrequested review from @apatterson2
- Resolved by Andrew Patterson
Do we need a note at https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/17b76b0f002cb2f4a4f044f000d6cc946a07ef21/lib/gitlab/package_repository.rb#L42 about SLES packages?
- Resolved by Andrew Patterson
- Resolved by Clemens Beck
- Resolved by Andrew Patterson
-
Green pipeline on gitlab.com at https://gitlab.com/gitlab-org/omnibus-gitlab/-/pipelines/1625987877. -
Failed pipeline on dev.gitlab.org at https://dev.gitlab.org/gitlab/omnibus-gitlab/-/jobs/25043311 with "ee=true". This failure should have nothing to do with this change.
-
Looping in @balasankarc. We do the same thing here for OL. I don't see an issue with doing the same here, and eventually, we can get rid of SLES builds.
added 26 commits
-
1725b1da...efead4ef - 24 commits from branch
master
- ecf28532 - Add support for SLES 15.6
- 8d109816 - Do not check OpenSUSE package version
-
1725b1da...efead4ef - 24 commits from branch
Thanks for the review @apatterson2. This is ready for another look.
LGTM.
-
Green pipeline on dev.gitlab.org at https://dev.gitlab.org/gitlab/omnibus-gitlab/-/pipelines/362507.
-
mentioned in commit 5b5d03a2
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in merge request gitlab-omnibus-builder!371 (merged)
mentioned in issue #8814 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label