Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • omnibus-gitlab omnibus-gitlab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,059
    • Issues 1,059
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 53
    • Merge requests 53
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • omnibus-gitlabomnibus-gitlab
  • Merge requests
  • !5316

[Omnibus] Allow configuring redis instance for trace chunks

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Bob Van Landuyt requested to merge bvl-add-redis-trace-chunks into master Jun 01, 2021
  • Overview 13
  • Commits 1
  • Pipelines 2
  • Changes 4

What does this MR do?

This allows adding a setting redis_trace_chunks_instance and redis_trace_chunks_sentinels in gitlab.rb to create a new configuration file for a separate redis instance to store trace chunks.

Changelog: added

Related issues

This is part of gitlab-com/gl-infra/scalability#1094 (closed)

The new instance will added to GitLab-rails in gitlab!62767 (merged)

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion

Required

  • Merge Request Title, and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • Pipeline is green on dev.gitlab.org if the change is touching anything besides documentation or internal cookbooks
  • trigger-package has a green pipeline running against latest commit

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes in combination with: gitlab-com/gl-infra/scalability#1095 (closed) this new Redis instance would be accessible from GitLab-rails
  • Documentation created/updated: The use of this extra Redis instance will be documented once we add the functionality in gitlab-com/gl-infra/scalability#1095 (closed)
  • Tests added
  • [-] Integration tests added to GitLab QA: This redis instance isn't used yet, but will be in: gitlab-com/gl-infra/scalability#1095 (closed) which will contain tests
  • Equivalent MR/issue for the GitLab Chart opened: gitlab-org/charts/gitlab!2031 (merged)
Edited Jun 02, 2021 by Bob Van Landuyt
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bvl-add-redis-trace-chunks