Skip to content
Snippets Groups Projects

Create the uploads_storage_path directory

Merged John Jarvis requested to merge jarv/create-uploads-directory into master
All threads resolved!

resolves https://gitlab.com/gitlab-org/release/framework/issues/392

local storage configuration

https://docs.gitlab.com/ee/administration/uploads.html#using-local-storage

we instruct users to set

 gitlab_rails['uploads_storage_path'] = "/mnt/storage/"

but this directory is not created by reconfigure.

this is only a problem when it is changed because the default is:

/var/opt/gitlab/gitlab-rails

object storage configuration

Currently, due to https://gitlab.com/gitlab-org/gitlab-ce/issues/47220 we still write to this directory when using object storage. Although in this case you probably would not change it from the default, if you do uploads will not work because the directory will not exist.

Edited by GitLab Release Tools Bot

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • John Jarvis added 1 commit

    added 1 commit

    • 2187491e - Create the uploads_storage_path directory

    Compare with previous version

  • John Jarvis changed the description

    changed the description

  • Author Developer

    @balasankarc could i get your thoughts on !3396 (diffs, comment 187382765) ? I am afraid this might not be as straightforward as I hope given that we default to the gitlab-rails directory.

  • John Jarvis added 1 commit

    added 1 commit

    • 185d2b2e - Fix the default path for uploads_storage_path in gitlab.rb.template

    Compare with previous version

  • John Jarvis added 1 commit

    added 1 commit

    • 9eda04a7 - Create uploads storage directory only if it is not the default

    Compare with previous version

  • John Jarvis added 1 commit

    added 1 commit

    • 86d33c99 - Create uploads storage directory only if it is not the default

    Compare with previous version

  • John Jarvis unmarked as a Work In Progress

    unmarked as a Work In Progress

  • John Jarvis resolved all threads

    resolved all threads

  • John Jarvis assigned to @balasankarc and unassigned @jarv

    assigned to @balasankarc and unassigned @jarv

  • John Jarvis added 1 commit

    added 1 commit

    • 5150a80d - Create uploads storage directory only if it is not the default

    Compare with previous version

  • John Jarvis added 1 commit

    added 1 commit

    • a7168b3d - Create uploads storage directory only if it is not the default

    Compare with previous version

  • John Jarvis added 31 commits

    added 31 commits

    • a7168b3d...9f2c6c09 - 28 commits from branch master
    • 5399649e - Create the uploads_storage_path directory
    • d3a2a4b5 - Fix the default path for uploads_storage_path in gitlab.rb.template
    • 3dd27634 - Create uploads storage directory only if it is not the default

    Compare with previous version

  • assigned to @jarv and unassigned @balasankarc

  • John Jarvis resolved all threads

    resolved all threads

  • John Jarvis added 1 commit

    added 1 commit

    • fd47a244 - Create uploads storage directory only if it is not the default

    Compare with previous version

  • John Jarvis assigned to @twk3 and unassigned @jarv

    assigned to @twk3 and unassigned @jarv

  • John Jarvis resolved all threads

    resolved all threads

  • DJ Mountney approved this merge request

    approved this merge request

  • merged

  • DJ Mountney mentioned in commit d73ca7a1

    mentioned in commit d73ca7a1

  • GitLab Release Tools Bot changed the description

    changed the description

  • Please register or sign in to reply
    Loading