Skip to content

Change wording of Checking for previous failed upgrade attempts: NOT OK

Summary

Similar to #4572 (which covers the Checking if we already upgraded: NOT OK message), this issue proposes that we change the wording of the Checking for previous failed upgrade attempts: NOT OK message when upgrading to make it less concerning/confusing, since NOT OK is the desired state.

Proposal

Update the wording from NOT OK to NONE FOUND in green, or likewise.

This will greatly improve the clarity of the message and lead to less confusion.

References

Running handlers:
[2025-06-05T20:56:21-05:00] INFO: Running report handlers
Running handlers complete
[2025-06-05T20:56:21-05:00] INFO: Report handlers complete
Infra Phase complete, 1/4 resources updated in 08 seconds
Checking PostgreSQL executables: OK
Checking if a newer PostgreSQL version is available and attempting automatic upgChecking for an omnibus managed postgresql: OK
Checking if postgresql['version'] is set: OK
Checking if we already upgraded: NOT OK
Checking for a newer version of PostgreSQL to install: OK
Upgrading PostgreSQL to 16.8
Checking for previous failed upgrade attempts: NOT OK
Checking if PostgreSQL bin files are symlinked to the expected location: OK
Toggling deploy page:cp /opt/gitlab/embedded/service/gitlab-rails/public/deploy.html /opt/gitlab/embedded/service/gitlab-rails/public/index.html
Toggling deploy page: OK