Simplify proxy_redirect when Pages listen_port is specified
@rmarshall Asked me to take a second look at the regexes. I don’t have any concerns there, but I do find the fact that we’re apparently using regexes to produce regex strings extremely confusing. I’m having a very difficult time figuring out exactly what should be produced in the configuration file without actually running the script.
I believe this works based on everyone else’s review, so I’m not going to challenge it in this review. However, we really shouldn’t need this much indirection. We *should. be able to produce a mostly-static configuration file that has all the regexes we need and simply substitute the right hostnames. That would be both easier to understand and probably better for performance. We also might be able to reduce the number of redirects, which would improve user experience.
If you think it’s possible, would you create an issue to look into it later, please?
This references this section of the Omnibus GitLab code to configure nginx
.