Follow-up from "Fix proxy_redirect when listen_port is specified for GitLab Pages"
The following discussion from !7604 (merged) should be addressed:
-
@rmarshall started a discussion: (+2 comments) @ngala - I think I understand what these re-writes do - but I do have a question:
We have all these re-writes here, but do we have a test somewhere that validates that when we pass through "X" it re-writes to "Y" and is correct more than just the
regex
expression exists?I think it would make it clearer what behaviors are supported and that our re-writes support it.
What do you think?