gitlab.rb redis['bind'] only accepts single IP address

Problem to solve

When a redis server has more than one IP address, specifying redis['bind'] in the gitlab.rb file only allows you to bind to a single IP address. This has the unfortunate side effect of not listening on the loopback address, 127.0.0.1 or ::1, which means that if you wish to check the redis health, you cannot use /opt/gitlab/embedded/bin/redis-cli -h localhost role to do so; you must look up the IP address of the machine on which you are running and use that.

The redis documentation shows that redis will accept space-separated IP addresses, and bind to all of them.

Proposal

gitlab-ctl reconfigure should not abort when multiple IP addresses are specified in redis['bind']

There was an error running gitlab-ctl reconfigure:

bad component(expected host component): 10.6.0.51 127.0.0.1 ::1

Intended users

Personas are described at https://about.gitlab.com/handbook/product/personas/

• Sidney (Systems Administrator)