gitlab-ctl should not attempt to re-register already registered oauth applications
The following discussion from !6310 (merged) should be addressed:
-
@balasankarc started a discussion: Not blocking, but something we should fix in the next iteration: With this change, subsequent
gitlab-ctl reconfigure
runs won't have any idea on whether an app has already been registered or not, and will attempt to register the app again. This is idempotent and hence relatively harmless, but will increase the duration of reconfigure run because each attempt requires the entire rails env to come up forrails runner
.Maybe we should have a dedicated setting per service, acting as a flag to decide whether or not to attempt registration.