Fail reconfigure when consolidated form is used to configure unsupported types
Summary
When working on this internal customer ticket @bnyaringita and I discovered that gitlab-ctl reconfigure would not report any configuration issues when this unsupported format is used:
gitlab_rails['object_store']['objects']['backup']['bucket'] = "backup-bucket-name"Instead, a reconfigure would succeed and the backup will be saved to a local directory.
Steps to reproduce
- Configure your GitLab instance to use object storage using consolidated configuration form.
- Add bucket configuration for one of the storage types that don't support consolidated configuration form:
gitlab_rails['object_store']['objects']['backup']['bucket'] = "backup-bucket-name"What is the current bug behavior?
No warning is reported by the reconfigure
What is the expected correct behavior?
Since this configuration is not supported, configure should report an error.