Check removals marked for 15.0 and ensure they have deprecation warnings in place

added devopssystems groupdistribution group::distributionbuild group::distributiondeploy sectioncore platform labels

mentioned in issue gitlab-org/distribution/team-tasks#1010 (closed)

changed milestone to %14.10

added Deliverable label

added priority3 label

added priority2 label and removed priority3 label

added [deprecated] Accepting merge requests label

mentioned in issue gitlab-org/quality/triage-reports#6911 (closed)

mentioned in issue gitlab-org/quality/triage-reports#6997 (closed)

changed due date to April 11, 2022

GitLab is launching a removals blog post on April 14 for breaking changes that will be genreated from the gitlab rails removals list. We need to ensure we are adding things there prior to that MR.

marked this issue as related to #6683 (closed)

assigned to @ghickey

Here is a checklist of the deprecations derived from https://docs.gitlab.com/ee/update/deprecations.html

Background upload for object storage (breaking change)
GitLab Pages running as a daemon
GitLab self-monitoring (breaking change)
GraphQL permissions change for Package settings (breaking change)
Move `custome_hooks_dir` setting from GitLab Shell to Gitaly
Permissions change for downloading Composer dependencies (breaking change)
htpassword Authentication for the Container Registry (breaking change)
`user_email_lookup_limit` API field (breaking change)
Changes to the `CI_JOB_JWT` (breaking change)
Container Network and Host Security (breaking change)
Dependency scanning Python3.9 and 3.6 image (breaking change)
Deprecate Geo Admin UI routes
Deprecate custom Geo:db:* Rake tasks
Deprecate feature flag `PUSH_RULES_SUPERSEDE_CODE_OWNERS` (breaking change)
Deprecate legacy Gitaly configuration methods (breaking change)
Elasticsearch 6.8 (breaking change)
External status check API (breaking change)
GraphQL ID and GlobalID compatibility (breaking change)
OAuth tokens without expiration (breaking change)
Optional enforcement of PAT expiration (breaking change)
Optional enforcement of SSH expiration (breaking change)
Out of the box SAST support for Java 8 (breaking change)
Querying usage trends via the `instanceStatisticsMeasurements` GraphQL node (breaking change)
Deprecate support for NFS repository storage (breaking change)
Request profiling (breaking change)
Required pipeline configurations in Premium tier (breaking change)
RetireJS dependency scanning tool (breaking change)
SAST analyzer consolidation and CI/CD template changes (breaking change)
SAST support for .NET 2.1 (breaking change)
Secret detection configuration variables deprecated
Secure and Protect analyzer images published in new location (breaking change)
Secure and Protect analyzer major version update (breaking change)
Support for gRPC-aware proxy deployed between Gitaly and rest of GitLab (breaking change)
Test coverage project CI/CD setting (breaking change)
Vulnerability check (breaking change)
`fixup!` commit messages setting draft status of associated MR
`projectFingerprint` in `PipelineSecurityReportFinding` GraphQL (breaking change)
`started` iterations API field (breaking change)
Container scanning schemas below `14.0.0`
Coverage guided fuzzing schemas below `14.0.0`
DAST schemas below '14.0.0'
Dependency scanning schemas below `14.0.0`
Enforced validation of security report schemas
Godep support in License Compliance
Logging in GitLab (breaking change)
Monitor performance metrics through Prometheus (breaking change)
Deprecate Pseudonymizer
SAST schemas below `14.0.0`
Secret detection schemas below `14.0.0`
Sidekiq metrics and health checks configuration (breaking change)
Static site editor
Tracing in GitLab (breaking change)
`artifacts:report:cobertuna` keyword (breaking change)
`merged_by` API field (breaking change)
API: `stale` status returned instead of `offline` or `not_connected` (breaking change)
CI/CD job name length limit (breaking change)
Legacy approval status names from License Compliance API (breaking change)
Runner status `not_connected` API value (breaking change)
`pipelines` fields in the Package GraphQL types (breaking change)
`type` and `types` keyword in CI/CD configuration
`apiFuzzingCiConfigurationCreate` GraphQL mutation (breaking change)
`bundler-audit` dependency scanning tool (breaking change)
Coverting an instance (shared) runner to a project (specific) runner (breaking change)
Known host required for GitLab Runner SSH executor (breaking change)
Must explicitly assign `AuthenticatonType` for `[runners.cache.s3]` (breaking change)
Package pipelines in API payload is paginated (breaking change)
REST and GraphQL API Runner status will not return `paused` (breaking change)
Support for SLES 12 SP2 (breaking change)
Update to Container Registry group-level API (breaking change)
Value stream analytics filtering calculation change (breaking change)
`Versions` on base `PackageType` (breaking change)
`defaultMergeCommitMessageWithDescription` GraphQL API field (breaking change)
`dependency_proxy_for_private_groups` feature flag (breaking change)
`pipelines` field from the `version` field (breaking change)
`promote-db` command from `gitlab-ctl` (breaking change)
`promote-to-primary-node` command from `gitlab-ctl` (breaking change)
Audit events for repository push events (breaking change)
GitLab Serverless (breaking change)
Legacy database configuration (breaking change)
OmniAuth Kerberos gem (breaking change)
OAuth implicit grant (breaking change)

This list is now to be disregarded given the comments by @twk3 below. This checklist has been reduced to the checklists in comments #6719 (comment 898295988), #6719 (comment 898300955), and #6719 (comment 898302910).

BTW that is 83 items for deprecation! I did find one that was a duplicate and removed the duplicate. If there is any other duplicates that someone sees, feel free to cross off the duplicates.

As I started looking into a couple of these I started to realize that some of the items don't apply given the issue description. I will go back and do a first pass to eliminate items that would not be reported as deprications in either the omnibus-gitlab or charts projects.

OK, now I am a bit confused. I have gone back through the list above and tried to determine which items would be exposed through configuration or accessible from Omnibus or a Chart install. Anything that did not seem to be based in configuration or seemed to be accessible I struck out on the list to make it a more manageable list.

After digging around a bit more I find in omnibus-gitlab the data/deprecations directory has most (if not all) of the above listed deprecations. Even if the deprecation does not fit the above criteria. In fact, I can not find any references to the content in data/deprecations in the gitlab/gitlab-ee container.

@ghickey https://docs.gitlab.com/ee/update/deprecations.html is populated automatically from https://gitlab.com/gitlab-org/gitlab/-/tree/master/data/deprecations

We need to make sure configuration file related ones also appear in https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/files/gitlab-cookbooks/package/libraries/deprecations.rb, and the ones for 15.0 in https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/files/gitlab-cookbooks/package/libraries/deprecations.rb appear back in data/deprecation as well so we aren't missing the sync of any.

Then also there might be some new ones that should be added to data/deprecations that are currently only available in issues, as that was our primary way of ensuring we do them for 15.0 https://gitlab.com/gitlab-org/omnibus-gitlab/-/issues?sort=created_date&state=opened&milestone_title=15.0 should represent those that we have noticed after the 15.0 milestone was available to be assigned to.

Finally we also need to search for issues that might be logged but not assigned to 15.0 due to the milestone not existing when we logged them. I'm not sure the best way to search for this, maybe @balasankarc has some ideas.

Grepping for TODO or 15.0 in the codebase might be worth a try.

Also, trying a global search on comments for 15.0 is another thing to try (maybe we mentioned it in MR reviews, but didn't do anything else) - https://gitlab.com/search?group_id=9970&project_id=20699&scope=notes&search=15.0.

I'll think a bit more and see if I come up with something else.

@twk3 You are right. I thought I was in omnibus-gitlab project seeing the data/deprecations. Just looked back at that terminal and yes, I was in the gitlab project. It makes much more sense to see the deprecations there than in omnibus-gitlab. That realization should hopefully keep me from going completely insane :-)

Well it looks like I have a few days of data scraping to do. Thanks for the info and ideas.

Thanks for working on this @ghickey! We've removed the Seeking community contributions label to avoid having multiple people working on the same issue.

removed [deprecated] Accepting merge requests label

Initial pass at configuration file related items

Background upload for object storage (breaking change)
Move custome_hooks_dir setting from GitLab Shell to Gitaly
~~user_email_lookup_limit API field (breaking change)~~
Deprecate legacy Gitaly configuration methods (breaking change)
~~Optional enforcement of PAT expiration (breaking change)~~
~~Optional enforcement of SSH expiration (breaking change)~~
Deprecate Pseudonymizer
Sidekiq metrics and health checks configuration (breaking change)
Legacy database configuration (breaking change)

Items listed in files/gitlab-cookbooks/package/libraries/deprecations.rb but not listed on the deprecations page:

Starting with GitLab 14.3, chroot has been removed along with disk-based configuration source. Because of this, the flag is a no-op and can be removed.
Use praefect['database_direct_host'] instead.
Use praefect['database_direct_port'] instead.
Starting with GitLab 14.5, Action Cable is enabled all the time. Because of this, the flag is a no-op and can be removed.
Use gitaly['runtime_dir'] instead.