Make it easier to ensure changes to Rails app won't break building in all OSs
As part of the review guidelines, if a new Gem is being added in GitLab, a review by Distribution team is required to ensure it builds fine in all OSs, does not increase package size, and does not violate any license restrictions we have in place.
However, doing this is currently a manual task that needs monkey patching CI config and VERSION files and manual pushes to dev.
We should ideally provide a manual action, like package-and-qa
for this, which could run a build in dev.gitlab.org (maybe similar to what we did with gitlab-omnibus-builder!179 (merged)).
Proposal
Add a manual job in the triggered package build pipeline (running in omnibus-gitlab-mirror
) which when played will start a pipeline in dev.gitlab.org passing necessary variables. We can make use of SKIP_JOB_REGEX
variable to ensure we don't duplicate builds.
One thing to note/decide if we want to build RPi packages also. Since RPi packages are building from gitlab-foss
and the MRs happen in gitlab
, this might be a bit tricky. But doable with the help of an additional variable FORCE_EE_BUILD
, which will force a build in all supported OSs irrespective of whether we are building CE or EE.