Unable to upgrade to 14.0 when using UDP log shipping

Because a value is automatically set for unicorn['svlogd_prefix'] when users have UDP logging enabled, upgrade to 14.0 will abort due to deprecated config check.

We should exempt unicorn['svlogd_prefix'] from config check.

Workarounds

Either of the following three workarounds can be used

  1. Temporarily disable UDP log shipping by unsetting logging['udp_log_shipping_host'] in your gitlab.rb, run reconfigure, upgrade to 14.0 and then re-enable it.

  2. If you are sure you don't use any other deprecated configuration, you can delete the JSON file in the directory /opt/gitlab/embedded/nodes and try upgrading again (without running a reconfigure before as a reconfigure will recreate that file). Please do note that this will override the deprecated configuration check. So do this only if you have no more deprecated config.

  3. Manually edit the file /opt/gitlab/embedded/cookbooks/package/libraries/deprecations.rb and change line 139 to the following (as shown in !5395 (merged)) and then run gitlab-ctl reconfigure and then attempt to upgrade to 14.0

    deprecations += identify_deprecated_config(existing_config, ['gitlab', 'unicorn'], ['enable', 'svlogd_prefix'], "13.10", "14.0", "Starting with GitLab 14.0, Unicorn is no longer supported and users must switch to Puma, following https://
docs.gitlab.com/ee/administration/operations/puma.html.")

    But, editing that file manually is neither recommended, nor supported. So make sure you make a backup of it before editing.

[Original issue description follows]

I have removed all unicorn settings from gitlab.rb and enabled puma, still on upgrade it fails with the following message: Deprecations:

Edited by Balasankar 'Balu' C