Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • omnibus-gitlab omnibus-gitlab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,061
    • Issues 1,061
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 67
    • Merge requests 67
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • omnibus-gitlabomnibus-gitlab
  • Issues
  • #5047
Closed
Open
Issue created Feb 03, 2020 by Michael Kozono@mkozono1️⃣Developer

Excess service restarts during zero-downtime upgrade

While upgrading GitLab according to https://docs.gitlab.com/omnibus/update/README.html#multi-node--ha-deployment-with-geo, there are two sections like:

For all nodes that run Unicorn, Sidekiq, or the geo-logcursor daemon

Hot reload unicorn, sidekiq and geo-logcursor services:

sudo gitlab-ctl hup unicorn
sudo gitlab-ctl restart sidekiq
sudo gitlab-ctl restart geo-logcursor

However if you scroll up into the gitlab-ctl reconfigure output, you will notice that it already restarted unicorn, sidekiq, and geo-logcursor services. The reconfigure step follows the apt-get install gitlab-ee step.

Two related problems

  1. We don't need reconfigure to restart unicorn during zero-downtime updates, we just want to hup it
  2. We don't need to restart these services in the instructions if reconfigure already did it

We need to check if this also affects non-Geo contexts (it seems likely.)

Edited Mar 01, 2021 by Michael Kozono
Assignee
Assign to
Time tracking